From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: git@amd.com, michal.simek@amd.com, lorenzo@kernel.org,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, radhey.shyam.pandey@amd.com,
srinivas.goud@amd.com, manion05gk@gmail.com
Subject: Re: [PATCH] iio: imu: lsm6dsx: Add shutdown callback support for I3C interface
Date: Mon, 21 Jul 2025 14:39:31 +0300 [thread overview]
Message-ID: <aH4m84n5UbCsktCM@smile.fi.intel.com> (raw)
In-Reply-To: <aH4mwkh80TUTNXtS@smile.fi.intel.com>
On Mon, Jul 21, 2025 at 02:38:42PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 21, 2025 at 04:37:41PM +0530, Manikanta Guntupalli wrote:
> > Add a shutdown handler for the ST LSM6DSx I3C driver to perform a hardware
> > reset during system shutdown. This ensures the sensor is placed in a
> > well-defined reset state, preventing issues during subsequent reboots,
> > such as kexec, where the device may fail to respond correctly during
> > enumeration.
>
> Do you imply that tons of device drivers missing this? I don't think we have
> even 5% of the drivers implementing the feature.
>
> > To support this, the previously static st_lsm6dsx_reset_device() function
> > is now exported via EXPORT_SYMBOL_NS() under the IIO_LSM6DSX namespace,
> > allowing it to be invoked from the I3C-specific driver.
>
> Why system suspend callback can't do this?
Ah, and why only I3C is important? Doesn't I2C or SPI also broken in this sense?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-21 11:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 11:07 [PATCH] iio: imu: lsm6dsx: Add shutdown callback support for I3C interface Manikanta Guntupalli
2025-07-21 11:38 ` Andy Shevchenko
2025-07-21 11:39 ` Andy Shevchenko [this message]
2025-07-22 7:19 ` Guntupalli, Manikanta
2025-09-19 11:10 ` Nuno Sá
2025-07-21 21:01 ` David Lechner
2025-07-22 7:32 ` Guntupalli, Manikanta
2025-07-22 7:56 ` Jorge Marques
2025-07-29 12:02 ` Guntupalli, Manikanta
2025-07-29 12:49 ` Jorge Marques
2025-07-30 6:27 ` Guntupalli, Manikanta
2025-09-05 5:29 ` Guntupalli, Manikanta
2025-09-18 7:22 ` Mario TESI
2025-09-19 9:22 ` Guntupalli, Manikanta
2025-09-19 11:18 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH4m84n5UbCsktCM@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=git@amd.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.