All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Shuah Khan <shuah@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH nf-next v4 1/2] net: netfilter: Add IPIP flowtable SW acceleration
Date: Mon, 21 Jul 2025 15:57:10 +0200	[thread overview]
Message-ID: <aH5HNm1VKqP-g5rB@strlen.de> (raw)
In-Reply-To: <aH5CvbR6zD7ENreo@lore-desk>

Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> I guess the point is we run nf_flow_skb_encap_protocol() not only for IPIP
> traffic but even for plain IP traffic (e.g. IP+UDP) in nf_flow_offload_lookup().
> In particular, we run the following check in nf_flow_tuple_ip() for IP+UDP
> traffic:
> 
> pskb_may_pull(, 28)
> 
> That is less restrictive with respect to
> 
> pskb_may_pull(, 40)

Its in different functions?  40 bytes in linear area is a prerequisite
for IPIP, and a check failure will not drop the skb; we'll still
progress onwards to .  But ok, it will be caught later too, so lets keep
it as-is.

  reply	other threads:[~2025-07-21 13:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 10:31 [PATCH nf-next v4 0/2] Add IPIP flowtable SW acceleratio Lorenzo Bianconi
2025-07-18 10:31 ` [PATCH nf-next v4 1/2] net: netfilter: Add IPIP flowtable SW acceleration Lorenzo Bianconi
2025-07-18 13:14   ` Florian Westphal
2025-07-21  9:49     ` Lorenzo Bianconi
2025-07-21 11:51       ` Florian Westphal
2025-07-21 13:38         ` Lorenzo Bianconi
2025-07-21 13:57           ` Florian Westphal [this message]
2025-07-18 10:31 ` [PATCH nf-next v4 2/2] selftests: netfilter: nft_flowtable.sh: Add IPIP flowtable selftest Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aH5HNm1VKqP-g5rB@strlen.de \
    --to=fw@strlen.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.