Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Jul 18, 2025 at 12:19:41PM -0400, Rodrigo Vivi wrote:
> On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote:
> > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote:
> > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest:
> > > convert drm_mm selftest to KUnit) and all functions under it were
> > > converted to KUnit, under the DRM_KUNIT_TEST option
> > > 
> > > This conversion however did not occur in the Kconfig.debug file in
> > > the
> > > i915 directory.
> 
> I wonder if some deeper conversion is needed on the selftests.
> But well, I couldn't spot anything and if CI is happy, let's go with ti.
> 
> > > 
> > > This patch replaces the select for DRM_DEBUG_SELFTEST, an option that
> > > no
> > > longer exists, with the correct select, DRM_KUNIT_TEST.
> > > 
> > > Signed-off-by: Ruben Wauters <rubenru09@aol.com>
> > > ---
> > > v2 changes:
> > > - update commit message to contain more detail about the background
> > > of
> > >   the change and why it is necessary
> > > ---
> > >  drivers/gpu/drm/i915/Kconfig.debug | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug
> > > b/drivers/gpu/drm/i915/Kconfig.debug
> > > index 1852e0804942..b15b1cecb3aa 100644
> > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > @@ -50,7 +50,7 @@ config DRM_I915_DEBUG
> > >  	select DRM_VGEM # used by igt/prime_vgem (dmabuf interop
> > > checks)
> > >  	select DRM_DEBUG_MM if DRM=y
> > >  	select DRM_EXPORT_FOR_TESTS if m
> > > -	select DRM_DEBUG_SELFTEST
> > > +	select DRM_KUNIT_TEST
> > >  	select DMABUF_SELFTESTS
> > >  	select SW_SYNC # signaling validation framework
> > > (igt/syncobj*)
> > >  	select DRM_I915_WERROR
> > 
> > Hello, I was wondering if it'd be possible to have this patch reviewed.
> > Having an incorrect Kconfig entry isn't ideal and it'd be good if this
> > could be fixed if possible
> 
> I just resent for CI before we can merge.

pushed to drm-intel-next

Thanks for the patch.

> 
> Thanks for the patch...
> 
> > 
> > Thanks
> > 
> > Ruben Wauters