All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jiqian Chen <Jiqian.Chen@amd.com>
Cc: xen-devel@lists.xenproject.org, Huang Rui <ray.huang@amd.com>
Subject: Re: [PATCH v7 6/8] vpci/rebar: Free Rebar resources when init_rebar() fails
Date: Mon, 21 Jul 2025 18:08:48 +0200	[thread overview]
Message-ID: <aH5mEI4WbdO1Wn3N@macbook.local> (raw)
In-Reply-To: <20250704070803.314366-7-Jiqian.Chen@amd.com>

On Fri, Jul 04, 2025 at 03:08:01PM +0800, Jiqian Chen wrote:
> When init_rebar() fails, current logic return fail and free Rebar-related
> resources in vpci_deassign_device(). But the previous new changes will
> hide Rebar capability and return success, it can't reach
> vpci_deassign_device() to remove resources if hiding success, so those
> resources must be removed in cleanup function of Rebar.
> 
> To do that, implement cleanup function for Rebar.
> 
> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


  reply	other threads:[~2025-07-21 16:09 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04  7:07 [PATCH v7 0/8] Support hiding capability when its initialization fails Jiqian Chen
2025-07-04  7:07 ` [PATCH v7 1/8] vpci/header: Emulate extended capability list for dom0 Jiqian Chen
2025-07-08 14:10   ` Jan Beulich
2025-07-09  5:29     ` Chen, Jiqian
2025-07-09  5:32       ` Jan Beulich
2025-07-09  5:34         ` Chen, Jiqian
2025-07-21 14:16           ` Roger Pau Monné
2025-07-23  6:45             ` Chen, Jiqian
2025-07-04  7:07 ` [PATCH v7 2/8] vpci: Refactor REGISTER_VPCI_INIT Jiqian Chen
2025-07-08 14:52   ` Jan Beulich
2025-07-21 14:37   ` Roger Pau Monné
2025-07-23  7:20     ` Chen, Jiqian
2025-07-23  8:19       ` Roger Pau Monné
2025-07-04  7:07 ` [PATCH v7 3/8] vpci: Hide legacy capability when it fails to initialize Jiqian Chen
2025-07-21 15:48   ` Roger Pau Monné
2025-07-23  7:33     ` Chen, Jiqian
2025-07-23  8:15       ` Roger Pau Monné
2025-07-04  7:07 ` [PATCH v7 4/8] vpci: Hide extended " Jiqian Chen
2025-07-21 16:04   ` Roger Pau Monné
2025-07-04  7:08 ` [PATCH v7 5/8] vpci: Refactor vpci_remove_register to remove matched registers Jiqian Chen
2025-07-04  7:08 ` [PATCH v7 6/8] vpci/rebar: Free Rebar resources when init_rebar() fails Jiqian Chen
2025-07-21 16:08   ` Roger Pau Monné [this message]
2025-07-04  7:08 ` [PATCH v7 7/8] vpci/msi: Free MSI resources when init_msi() fails Jiqian Chen
2025-07-08 15:13   ` Jan Beulich
2025-07-09  6:10     ` Chen, Jiqian
2025-07-09  6:49       ` Jan Beulich
2025-07-21 16:21   ` Roger Pau Monné
2025-07-23  7:54     ` Chen, Jiqian
2025-07-23  9:39       ` Jan Beulich
2025-07-04  7:08 ` [PATCH v7 8/8] vpci/msix: Free MSIX resources when init_msix() fails Jiqian Chen
2025-07-21 16:24   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aH5mEI4WbdO1Wn3N@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=ray.huang@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.