All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Anthoine Bourgeois" <anthoine.bourgeois@vates.tech>
To: "Elliott Mitchell" <ehem+xen@m5p.com>
Cc: xen-devel@lists.xenproject.org, "Juergen Gross" <jgross@suse.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Andrei Semenov" <andrei.semenov@vates.tech>
Subject: Re: [PATCH] xen/netfront: Fix TX response spurious interrupts
Date: Fri, 11 Jul 2025 07:41:02 +0000	[thread overview]
Message-ID: <aHDAC3mvysH-0vit@mail.vates.tech> (raw)
In-Reply-To: <aHAdG-vhZqdLeOpg@mattapan.m5p.com>

On Thu, Jul 10, 2025 at 01:05:47PM -0700, Elliott Mitchell wrote:
>On Thu, Jul 10, 2025 at 04:11:15PM +0000, Anthoine Bourgeois wrote:
>> We found at Vates that there are lot of spurious interrupts when
>> benchmarking the PV drivers of Xen. This issue appeared with a patch
>> that addresses security issue XSA-391 (see Fixes below). On an iperf
>> benchmark, spurious interrupts can represent up to 50% of the
>> interrupts.
>
>If this is the correct fix, near-identical fixes are needed for *all*
>of the Xen front-ends.  Xen virtual block-devices and Xen PCI-passthrough
>devices are also effected by a similar issue.
>
blkfront doesn't call the response handle from multiple places. It
doesn't seem to be affected by this problem.
And pcifront neither.

>Thanks for finding a candidate fix, this effects many other people who
>have been troubled by this performance issue.
>
>FreeBSD will also need a similar fix.

In FreeBSD, netfront may also be affected.
xn_assemble_tx_request calls xn_txeof.
blkfront and pcifront seems good.

Regards,
Anthoine


Anthoine Bourgeois | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech



  reply	other threads:[~2025-07-11  7:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 16:11 [PATCH] xen/netfront: Fix TX response spurious interrupts Anthoine Bourgeois
2025-07-10 20:05 ` Elliott Mitchell
2025-07-11  7:41   ` Anthoine Bourgeois [this message]
2025-07-11 21:22     ` Elliott Mitchell
2025-07-11  9:29 ` Teddy Astie
2025-07-11 15:27   ` Jürgen Groß
2025-07-11 15:28 ` Jürgen Groß
2025-07-11 15:33 ` Juergen Gross
2025-07-14  7:11   ` Anthoine Bourgeois
2025-07-15  0:37     ` Elliott Mitchell
2025-07-15  8:21       ` Anthoine Bourgeois
2025-07-15 19:19         ` Elliott Mitchell
2025-07-16  7:47           ` Anthoine Bourgeois
2025-07-16 18:31             ` Elliott Mitchell
2025-07-18 20:48               ` Elliott Mitchell
2025-07-21  9:51                 ` Anthoine Bourgeois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHDAC3mvysH-0vit@mail.vates.tech \
    --to=anthoine.bourgeois@vates.tech \
    --cc=andrei.semenov@vates.tech \
    --cc=ehem+xen@m5p.com \
    --cc=jgross@suse.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.