From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Feng Tang <feng.tang@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH v1 7/7] panic: sys_info: Factor out read and write handlers
Date: Fri, 11 Jul 2025 19:34:24 +0300 [thread overview]
Message-ID: <aHE9EEbsCuDOfD3J@smile.fi.intel.com> (raw)
In-Reply-To: <aHEpHEtnPms2LUi-@U-2FWC9VHC-2323.local>
On Fri, Jul 11, 2025 at 11:09:16PM +0800, Feng Tang wrote:
> On Fri, Jul 11, 2025 at 12:51:13PM +0300, Andy Shevchenko wrote:
> > For the sake of the code readability and easier maintenance
> > factor out read and write sys_info handlers.
>
> IIRC, I did implement separate 'write' handler, but chose not
> to do that to save some common definition. I guess it's personal
> preference, and I'm fine with either one.
It looks better, in my opinion, to be three functions.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-11 16:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:51 [rft, PATCH v1 0/7] panic: sys_info: Refactor and fix a compilation issue Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 1/7] Revert "panic: fix compilation error (`make W=1`)" Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 2/7] panic: sys_info: Align constant definition names with parameters Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 3/7] panic: sys_info: Capture si_bits_global before iterating over it Andy Shevchenko
2025-07-11 14:56 ` Feng Tang
2025-07-11 15:05 ` Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 4/7] panic: sys_info: Replace struct sys_info_name with plain array of strings Andy Shevchenko
2025-07-11 15:21 ` Feng Tang
2025-07-11 16:26 ` Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 5/7] panic: sys_info: Fix compilation error (`make W=1`) Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 6/7] panic: sys_info: Deduplicate local variable 'table; assignments Andy Shevchenko
2025-07-11 9:51 ` [PATCH v1 7/7] panic: sys_info: Factor out read and write handlers Andy Shevchenko
2025-07-11 15:09 ` Feng Tang
2025-07-11 16:34 ` Andy Shevchenko [this message]
2025-07-11 12:13 ` [rft, PATCH v1 0/7] panic: sys_info: Refactor and fix a compilation issue Andy Shevchenko
2025-07-11 15:42 ` Feng Tang
2025-07-11 16:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHE9EEbsCuDOfD3J@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.