From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: LiangCheng Wang <zaq14760@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v9 1/3] staging: media: atomisp: fix indentation in aa
Date: Fri, 11 Jul 2025 15:22:07 +0300 [thread overview]
Message-ID: <aHEB70JWm1sotEXI@smile.fi.intel.com> (raw)
In-Reply-To: <20250711-new_atomisp-v9-1-a9dd62425ef6@gmail.com>
On Fri, Jul 11, 2025 at 07:54:36PM +0800, LiangCheng Wang wrote:
> This patch fixes tab/space indentation issues in aa
The Submitting Patches insists to use imperative mode.
> following kernel coding style guidelines.
No, currently the code does something different, you forgot to update
the commit message. Something like
"""
Move a standalone kernel-doc comment of the 'strength' field of
the struct ia_css_aa_config to the whole-structure one.
"""
...
> Link: https://lore.kernel.org/all/CAHp75Vfc7QsENHsaYMKau_4DU3-LmW2XaUxd=oHqTS3F3R85eg@mail.gmail.com/
> Link: https://lore.kernel.org/all/e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org/
Unneeded Link tags. It actually doesn't matter when and how it was suggested,
the relevant people are automatically added to Cc list.
The rule of thumb is that the person who suggested the change (in terms of
Suggested-by tag) should also provide at least Acked-by (or Reviewed-by).
It can be optional if that person is the same as the committer of the changes
(depends on them and respective maintainers).
> ---
Code wise LGTM.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-11 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 11:54 [PATCH v9 0/3] staging: media: atomisp: indentation cleanup per directory LiangCheng Wang
2025-07-11 11:54 ` [PATCH v9 1/3] staging: media: atomisp: fix indentation in aa LiangCheng Wang
2025-07-11 12:22 ` Andy Shevchenko [this message]
2025-07-11 11:54 ` [PATCH v9 2/3] staging: media: atomisp: fix indentation in anr LiangCheng Wang
2025-07-11 12:25 ` Andy Shevchenko
2025-07-11 11:54 ` [PATCH v9 3/3] staging: media: atomisp: fix indentation in bh LiangCheng Wang
2025-07-11 12:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHEB70JWm1sotEXI@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=zaq14760@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.