From: Benson Leung <bleung@google.com>
To: Jameson Thies <jthies@google.com>
Cc: abhishekpandit@chromium.org, ukaszb@chromium.org,
bleung@chromium.org, heikki.krogerus@linux.intel.com,
akuchynski@chromium.org, mattedavis@google.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: ucsi: Add poll_cci operation to cros_ec_ucsi
Date: Fri, 11 Jul 2025 20:40:38 +0000 [thread overview]
Message-ID: <aHF2xpf5LMTm1B8Q@google.com> (raw)
In-Reply-To: <20250711202033.2201305-1-jthies@google.com>
On Fri, Jul 11, 2025 at 08:20:33PM +0000, Jameson Thies wrote:
> cros_ec_ucsi fails to allocate a UCSI instance in it's probe function
> because it does not define all operations checked by ucsi_create.
> Update cros_ec_ucsi operations to use the same function for read_cci
> and poll_cci.
>
> Signed-off-by: Jameson Thies <jthies@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/usb/typec/ucsi/cros_ec_ucsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> index 4ec1c6d22310..eed2a7d0ebc6 100644
> --- a/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> +++ b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> @@ -137,6 +137,7 @@ static int cros_ucsi_sync_control(struct ucsi *ucsi, u64 cmd, u32 *cci,
> static const struct ucsi_operations cros_ucsi_ops = {
> .read_version = cros_ucsi_read_version,
> .read_cci = cros_ucsi_read_cci,
> + .poll_cci = cros_ucsi_read_cci,
> .read_message_in = cros_ucsi_read_message_in,
> .async_control = cros_ucsi_async_control,
> .sync_control = cros_ucsi_sync_control,
>
> base-commit: b4b4dbfa96dea8e299a47ef877eb0cfe210a7291
> --
> 2.50.0.727.gbf7dc18ff4-goog
>
prev parent reply other threads:[~2025-07-11 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 20:20 [PATCH v1] usb: typec: ucsi: Add poll_cci operation to cros_ec_ucsi Jameson Thies
2025-07-11 20:40 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHF2xpf5LMTm1B8Q@google.com \
--to=bleung@google.com \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mattedavis@google.com \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.