From: Steffen Klassert <steffen.klassert@secunet.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: <netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH ipsec 0/2] ipsec: fix splat due to ipcomp fallback tunnel
Date: Mon, 14 Jul 2025 09:02:12 +0200 [thread overview]
Message-ID: <aHSrdJoHLtp6eIGK@gauss3.secunet.de> (raw)
In-Reply-To: <cover.1751640074.git.sd@queasysnail.net>
On Fri, Jul 04, 2025 at 04:54:32PM +0200, Sabrina Dubroca wrote:
> IPcomp tunnel states have an associated fallback tunnel, a keep a
> reference on the corresponding xfrm_state, to allow deleting that
> extra state when it's not needed anymore. These states cause issues
> during netns deletion.
>
> Commit f75a2804da39 ("xfrm: destroy xfrm_state synchronously on net
> exit path") tried to address these problems but doesn't fully solve
> them, and slowed down netns deletion by adding one synchronize_rcu per
> deleted state.
>
> The first patch solves the problem by moving the fallback state
> deletion earlier (when we delete the user state, rather than at
> destruction), then we can revert the previous fix.
>
> Sabrina Dubroca (2):
> xfrm: delete x->tunnel as we delete x
> Revert "xfrm: destroy xfrm_state synchronously on net exit path"
Series applied, thanks Sabrina!
prev parent reply other threads:[~2025-07-14 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 14:54 [PATCH ipsec 0/2] ipsec: fix splat due to ipcomp fallback tunnel Sabrina Dubroca
2025-07-04 14:54 ` [PATCH ipsec 1/2] xfrm: delete x->tunnel as we delete x Sabrina Dubroca
2025-07-04 14:54 ` [PATCH ipsec 2/2] Revert "xfrm: destroy xfrm_state synchronously on net exit path" Sabrina Dubroca
2025-07-14 7:02 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHSrdJoHLtp6eIGK@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=adobriyan@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.