From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] drm/format-helper: introduce drm_fb_xrgb8888_to_gray2()
Date: Mon, 14 Jul 2025 11:53:28 +0200 [thread overview]
Message-ID: <aHTTmORf7aoPxZdu@gmail.com> (raw)
In-Reply-To: <bc37c3e9-0e58-4d63-b271-d2b026adf3a0@suse.de>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Hi Thomas,
Thank you for your comments!
On Mon, Jul 14, 2025 at 11:13:04AM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 14.07.25 um 10:04 schrieb Marcus Folkesson:
> > drm_fb_xrgb8888_to_gray2() works like and share much code with
> > drm_fb_xrgb8888_to_mono(), but converts XRGB8888 to
> > 2bit grayscale instead.
> >
> > It uses drm_fb_xrgb8888_to_gray8() to convert the pixels to gray8 as an
> > intermediate step before converting to gray2.
>
> Please don't share code here. This needs a serious rework anyway. The best
> thing for now is to add a new, separate function for _gray2().
I see. I will instead add a separate _gray() function, even though it
will look very similar to _mono.
>
> Best regards
> Thomas
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-07-14 9:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 8:03 [PATCH 0/5] drm/st7571-i2c: add support for grayscale xrgb8888 Marcus Folkesson
2025-07-14 8:03 ` [PATCH 1/5] drm/st7571-i2c: correct pixel data format description Marcus Folkesson
2025-07-14 10:48 ` Javier Martinez Canillas
2025-07-14 8:04 ` [PATCH 2/5] dt-bindings: display: sitronix,st7571: add optional inverted property Marcus Folkesson
2025-07-14 10:51 ` Javier Martinez Canillas
2025-07-14 11:01 ` Marcus Folkesson
2025-07-15 3:39 ` Rob Herring
2025-07-14 8:04 ` [PATCH 3/5] drm/st7571-i2c: add support inverted pixel format Marcus Folkesson
2025-07-14 10:51 ` Javier Martinez Canillas
2025-07-14 8:04 ` [PATCH 4/5] drm/format-helper: introduce drm_fb_xrgb8888_to_gray2() Marcus Folkesson
2025-07-14 9:13 ` Thomas Zimmermann
2025-07-14 9:53 ` Marcus Folkesson [this message]
2025-07-14 8:04 ` [PATCH 5/5] drm/st7571-i2c: add support for 2bit grayscale for XRGB8888 Marcus Folkesson
2025-07-14 10:56 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHTTmORf7aoPxZdu@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.