From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, djwong@kernel.org, willy@infradead.org
Subject: Re: [PATCH v2 7/7] xfs: error tag to force zeroing on debug kernels
Date: Mon, 14 Jul 2025 09:42:38 -0400 [thread overview]
Message-ID: <aHUJToKyf6cq4T2f@bfoster> (raw)
In-Reply-To: <aHUEtVJK6PPepNde@infradead.org>
On Mon, Jul 14, 2025 at 06:23:01AM -0700, Christoph Hellwig wrote:
> On Mon, Jul 14, 2025 at 09:20:59AM -0400, Brian Foster wrote:
> > - error = xfs_free_file_space(XFS_I(inode), offset, len, ac);
> > - if (error)
> > - return error;
> > + /* randomly force zeroing to exercise zero range */
>
> This comment feels very sparse for this somewhat confusing behavior.
> Can you add a shortened version of the commit message here explaining
> why this is useful?
>
Sure, will fix.
Brian
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
next prev parent reply other threads:[~2025-07-14 13:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:20 [PATCH v2 0/7] iomap: zero range folio batch support Brian Foster
2025-07-14 13:20 ` [PATCH v2 1/7] filemap: add helper to look up dirty folios in a range Brian Foster
2025-07-14 13:19 ` Christoph Hellwig
2025-07-14 13:20 ` [PATCH v2 2/7] iomap: move pos+len BUG_ON() to after folio lookup Brian Foster
2025-07-14 13:20 ` Christoph Hellwig
2025-07-14 13:42 ` Brian Foster
2025-07-14 13:20 ` [PATCH v2 3/7] iomap: optional zero range dirty folio processing Brian Foster
2025-07-14 13:20 ` Christoph Hellwig
2025-07-14 13:20 ` [PATCH v2 4/7] xfs: always trim mapping to requested range for zero range Brian Foster
2025-07-14 13:20 ` [PATCH v2 5/7] xfs: fill dirty folios on zero range of unwritten mappings Brian Foster
2025-07-14 13:21 ` Christoph Hellwig
2025-07-14 13:20 ` [PATCH v2 6/7] iomap: remove old partial eof zeroing optimization Brian Foster
2025-07-14 13:20 ` [PATCH v2 7/7] xfs: error tag to force zeroing on debug kernels Brian Foster
2025-07-14 13:23 ` Christoph Hellwig
2025-07-14 13:42 ` Brian Foster [this message]
2025-07-14 14:12 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHUJToKyf6cq4T2f@bfoster \
--to=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.