From: Sean Christopherson <seanjc@google.com>
To: Nikunj A Dadhania <nikunj@amd.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org,
thomas.lendacky@amd.com, santosh.shukla@amd.com, bp@alien8.de,
Michael Roth <michael.roth@amd.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] KVM: SEV: Enforce minimum GHCB version requirement for SEV-SNP guests
Date: Mon, 14 Jul 2025 07:29:44 -0700 [thread overview]
Message-ID: <aHUUWMnTBfcRO7Uj@google.com> (raw)
In-Reply-To: <85ple4go0k.fsf@amd.com>
On Sun, Jul 13, 2025, Nikunj A Dadhania wrote:
> Sean Christopherson <seanjc@google.com> writes:
>
> > On Fri, Jul 11, 2025, Nikunj A Dadhania wrote:
> >> Require a minimum GHCB version of 2 when starting SEV-SNP guests through
> >> KVM_SEV_INIT2. When a VMM attempts to start an SEV-SNP guest with an
> >> incompatible GHCB version (less than 2), reject the request early rather
> >> than allowing the guest to start with an incorrect protocol version and
> >> fail later.
> >
> > What happens with ghcb_version==1? I.e. what failure occurs, and
> > when?
>
> SNP guest terminates with following error:
So this probably isn't stable@ worth then? Because I don't see any risk to the
kernel, this is ultimately only a problem if the VMM is broken, and the "fix"
doesn't provide any meaningful change in functionality (the VM is dead no matter
what).
next prev parent reply other threads:[~2025-07-14 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 4:54 [PATCH] KVM: SEV: Enforce minimum GHCB version requirement for SEV-SNP guests Nikunj A Dadhania
2025-07-11 13:07 ` Sean Christopherson
2025-07-13 14:32 ` Nikunj A Dadhania
2025-07-14 14:29 ` Sean Christopherson [this message]
2025-07-15 6:08 ` Nikunj A Dadhania
2025-07-11 21:42 ` kernel test robot
2025-07-13 14:33 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHUUWMnTBfcRO7Uj@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=kvm@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=santosh.shukla@amd.com \
--cc=stable@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.