All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiang Mei <xmei5@asu.edu>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	netdev@vger.kernel.org, gregkh@linuxfoundation.org,
	jhs@mojatatu.com, jiri@resnulli.us, security@kernel.org
Subject: Re: [PATCH v3] net/sched: sch_qfq: Fix race condition on qfq_aggregate
Date: Mon, 14 Jul 2025 17:09:42 -0700	[thread overview]
Message-ID: <aHWcRp7mB-AXcFKd@xps> (raw)
In-Reply-To: <20250714153223.5137cafe@kernel.org>

On Mon, Jul 14, 2025 at 03:32:23PM -0700, Jakub Kicinski wrote:
> On Sun, 13 Jul 2025 17:04:24 -0700 Xiang Mei wrote:
> > Please let me know if I made any mistake while testing:
> > 1) Apply the patch to an lts version ( I used 6.6.97)
> 
> Please test net/main, rather than LTS:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/

Thanks for the information. I re-tested on the latest version of net/main,
which contained my patch, but it doesn't crash on 5e6d. I re-verified 
this patch and can't connect it with a null-deref in dequeue.


Here is more information no how I tested:

1) I ran `python3 ./tdc.py -f ./tc-tests/infra/qdiscs.json -e 5e6d` 100
times
2) The KASAN is enabled, and my patch is on it
3) All 100 results show `ok 1 5e6d - Test QFQ's enqueue reentrant behaviour
with netem` without any crashing in dmesg

I may need more information to trace this crash.

  reply	other threads:[~2025-07-15  0:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 10:09 [PATCH v3] net/sched: sch_qfq: Fix race condition on qfq_aggregate Xiang Mei
2025-07-10 21:29 ` Cong Wang
2025-07-10 22:38   ` Xiang Mei
2025-07-13 21:31     ` Cong Wang
2025-07-13 21:34       ` Xiang Mei
2025-07-14  0:04       ` Xiang Mei
2025-07-14 22:32         ` Jakub Kicinski
2025-07-15  0:09           ` Xiang Mei [this message]
2025-07-15 17:23             ` Cong Wang
2025-07-15 18:13             ` Cong Wang
2025-07-15 22:16               ` Xiang Mei
2025-07-12 23:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHWcRp7mB-AXcFKd@xps \
    --to=xmei5@asu.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.