From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09CAC83F35 for ; Tue, 15 Jul 2025 20:05:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60E396B009C; Tue, 15 Jul 2025 16:05:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EBD46B009D; Tue, 15 Jul 2025 16:05:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FBCA6B009E; Tue, 15 Jul 2025 16:05:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 403FD6B009C for ; Tue, 15 Jul 2025 16:05:40 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 143EA10CB41 for ; Tue, 15 Jul 2025 20:05:40 +0000 (UTC) X-FDA: 83667579240.27.1A883CD Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 9A8DB4000C for ; Tue, 15 Jul 2025 20:05:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mrvQPjIp; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752609938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S/KKwuIU0E5O0qishV0kvTHZX0T0jOTzEqHSNU/nUd0=; b=pUrma1B4iNS8Byt8Y0KXw94lpekrsI517IrWnQ0RDj9jjXZuuc4lTqFmYvrIs/mEo9D3RF 02RM08eC7Y/MHkdRGippAd6/PmwMx1UbQMAuHQM7vP/5RS5uU2qeeuG98thAUzsTBwnCu5 Xq+G6DZ75FCcWBHdpYnCcsQQS7imLrg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752609938; a=rsa-sha256; cv=none; b=LOPL5awPmTCcRfzWnCiIMM2ukNp1XQi/9DWLoSSoPihYeYHwxhXCa725ecpQQzvOCTMBq3 vQ/1Vh/U/XIvL4JZWo/O5kgdvjiAPcbox/o+d+GCbUozmz7AIf/T+yrqPywotGgiM4wJa1 VRlcg+7i1wBcclDYkpa3Kb2nNj7fQ8Q= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mrvQPjIp; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 064EFA57260; Tue, 15 Jul 2025 20:05:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D06F7C4CEE3; Tue, 15 Jul 2025 20:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752609937; bh=HGj+b5u2y+iRJezZTE2uihoa30LW+LxcNFrFq2MAUlE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mrvQPjIpDnV1MFMJeONfPse+7A86XoXMkrz/2eVyoOlGXoGLsE2A4ohd5aUN30nqB Q/VaCwaIHdIfveQaYBw8ML/EkxQjH/KqpJcMEiaZdl3bCzpT0o74czN3yuAdk8SA2w Q3yASUODws5cAcM7753ikIstGlUMsZVHfhScedb8YDW8xv/kSSSp6SsB+iRevL1kMw mr0e5ZpDdBQrOYLYP9Z2nEEfs2EOYlIRY1Ppj1q6ePC3rDNKFtOxgWEshK0ALAJ3V5 FtHTd7aV5ZfAgBmk0danbYoRmczvD7qwY4uvEQD7EtDZc9O+ULoYXQ0lkde/QJ6NXT AUahiMHx18ewQ== Date: Tue, 15 Jul 2025 13:05:35 -0700 From: Namhyung Kim To: Ankur Arora Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, david@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org, acme@kernel.org, tglx@linutronix.de, willy@infradead.org, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH v5 02/14] perf bench mem: Defer type munging of size to float Message-ID: References: <20250710005926.1159009-1-ankur.a.arora@oracle.com> <20250710005926.1159009-3-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250710005926.1159009-3-ankur.a.arora@oracle.com> X-Rspamd-Queue-Id: 9A8DB4000C X-Stat-Signature: 5cpctm4ntkmtenumb3yr489m7rz4h5nz X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752609938-635575 X-HE-Meta: U2FsdGVkX18qo/5TEhAhVxxsmAEtUb5WATuqGl5AMPW37VtqIMs8sK/xW5BAv590aPeTQqArpCRjgVmmIc85MnLtclhmaUZnEUePo2vU30CMXKbhy6Hnfkx/A8zFy43rFhK5LKpzoBMXAaB5nJqieeBzOtYQXWSNk5iwRjNonZpPMy0zGZeB+50RxyfX33fiwcWPo+H6012Mf+EtzAJZQsLxRWpb5txyKAp/7c4O87o4CCJa70x6EDL7oTjP1w4yqWnCJFwD39IOd7C0Ay+3ONWEJoKoWr7o6xufHzaXFitt/jHvVpta+VenSqetV82Yz31fFGPejxguHHQszdl5TArS8Q4D/T/XDC7bO43SaU/OQczcTlpLj6utoSyxnUU22z+73Jm+gHcmgXaBka5GLGUmUVL3wsPmmm+3WPWYf4d7d6Hm43VIlYJ4TWtnhSkGMKIURXBE+RREBRnLogZ9TO0EYM0Ph6dZjYHBhN9/LV7S1gv6pxrLYu2n+aBPuP2H11SB3ChjHxKf/Tn6uBMNxqrDWe4X7QyI3rBZjgkF+2Do5m0h7jIZI4gH36SYJ/EmY9ShzOepD1qgp09z4Hn5laI4lWEbQ7GWGLDmVdbncml5rZPvpNdRB4+hXt8b9Ah5hNchUpPnYWihzuL/xY7hL4heAYXyjb5GjRZVMWE13cYiC7XUT7RE/ai1o1TWM8tRoRzo/z2TPqvYXQXcpF6Ro5ZXBrBEC4ysREOyN6cyTUdPW9Kpokolkh9TyS5zogmlD21ios+/UDhMXTM9MAq48i0Kxza4Sf/bdc5CwmKCQ4+CE9utkqaqLQZnYXBejaWhsSNQqQZacEl/Ly2+LewGlL+B6QOkpxl4ic8lXXVnAcbqs2qhU8QagiW3zUmhtajSglyWP3P98bQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 09, 2025 at 05:59:14PM -0700, Ankur Arora wrote: > Do type conversion to double at the point of use. > > Signed-off-by: Ankur Arora Reviewed-by: Namhyung Kim A nitpick below. > --- > tools/perf/bench/mem-functions.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/bench/mem-functions.c b/tools/perf/bench/mem-functions.c > index 8599ed96ee1f..b8f020379197 100644 > --- a/tools/perf/bench/mem-functions.c > +++ b/tools/perf/bench/mem-functions.c > @@ -139,7 +139,7 @@ struct bench_mem_info { > bool alloc_src; > }; > > -static void __bench_mem_function(struct bench_mem_info *info, int r_idx, size_t size, double size_total) > +static void __bench_mem_function(struct bench_mem_info *info, int r_idx, size_t size, size_t size_total) > { > const struct function *r = &info->functions[r_idx]; > double result_bps = 0.0; > @@ -165,18 +165,18 @@ static void __bench_mem_function(struct bench_mem_info *info, int r_idx, size_t > switch (bench_format) { > case BENCH_FORMAT_DEFAULT: > if (use_cycles) { > - printf(" %14lf cycles/byte\n", (double)rt.cycles/size_total); > + printf(" %14lf cycles/byte\n", (double)rt.cycles/(double)size_total); > } else { > - result_bps = size_total/timeval2double(&rt.tv); > + result_bps = (double)size_total/timeval2double(&rt.tv); > print_bps(result_bps); > } > break; > > case BENCH_FORMAT_SIMPLE: > if (use_cycles) { > - printf("%lf\n", (double)rt.cycles/size_total); > + printf("%lf\n", (double)rt.cycles/(double)size_total); > } else { > - result_bps = size_total/timeval2double(&rt.tv); > + result_bps = (double)size_total/timeval2double(&rt.tv); > printf("%lf\n", result_bps); > } > break; > @@ -199,7 +199,7 @@ static int bench_mem_common(int argc, const char **argv, struct bench_mem_info * > { > int i; > size_t size; > - double size_total; > + size_t size_total; > > argc = parse_options(argc, argv, options, info->usage, 0); > > @@ -212,7 +212,7 @@ static int bench_mem_common(int argc, const char **argv, struct bench_mem_info * > } > > size = (size_t)perf_atoll((char *)size_str); > - size_total = (double)size * nr_loops; > + size_total = (size_t)size * nr_loops; No need to cast. Thanks, Namhyung > > if ((s64)size <= 0) { > fprintf(stderr, "Invalid size:%s\n", size_str); > -- > 2.43.5 >