From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59EB87464; Tue, 15 Jul 2025 19:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752606394; cv=none; b=cGBMiSKoqfzm3m/zkOuh3TmSX19G4vlaCWIPKOdc3KSehh+1CPzrnTv8ZmAZn22pcOIo4NxkqNRi3CskLRtXBgmk3GnLQSAz+YKj9uwiFLsnPXQT9nY63ls79CBOalFDKGKuRWpJNZlJ8kCxNtyPeem/sz1HHjCv+ODbmNaASoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752606394; c=relaxed/simple; bh=L+UQBQ3ecguB16JTjOLfSGjZZddbOdM1WxYkXwjr/YI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cYPae2X6fVUjRgexHmtq6gQ/7DI6Wxswslwvb+PyUD2G13Uc1CXwE1aEqyzQ5xJYBv69eT1vBaRpb7oJRvYjhTmVSHdKjPuOxrzve9qllwPzraXixlzRZ4TA6U/jwMuWES6F8CtYGfYEiIQvT+NxDLz0oR01UUCHJffIMdTxf6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DRfxLC0S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DRfxLC0S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99262C4CEE3; Tue, 15 Jul 2025 19:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752606393; bh=L+UQBQ3ecguB16JTjOLfSGjZZddbOdM1WxYkXwjr/YI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRfxLC0SWJJusMpZzlnz8OOsc6RIgOzny0xeuAyDOgRSIxKjXc3P+nGfrl+9XSYBy 9goqUu42xNbnAoO01ATRrA7vmlJf47O5LUrfhcuHoFNWROMjVL1QdbQmbFdP2bBPkB Xf3RmNZRT34Fddz1p6KJYZarPh9m5/M9CMAfA/LlLxigK9DxmAH9Dd+3nTRa+JCApI 1gpbOZkJapyRlMnHOAIdRjmwMsxQ3n7AHJ8kam5G1D0hLIlLmZxE8JnXyoFqG4Hu43 BCrpX5s0Gb6ufyGUgCGH2EIn4SjzycI6H2OeffymU6K0vY497is7rGRlB4yOLXt31x yaF7wGKpAyueQ== Date: Tue, 15 Jul 2025 15:04:53 -0400 From: Sasha Levin To: Kurt Borja Cc: Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, Mark Pearson , Ilpo =?iso-8859-1?Q?J=E4rvinen?= Subject: Re: [PATCH 5.15 53/77] platform/x86: think-lmi: Fix sysfs group cleanup Message-ID: References: <20250715130751.668489382@linuxfoundation.org> <20250715130753.855799519@linuxfoundation.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 15, 2025 at 03:38:58PM -0300, Kurt Borja wrote: >Hi Greg, > >On Tue Jul 15, 2025 at 10:13 AM -03, Greg Kroah-Hartman wrote: >> 5.15-stable review patch. If anyone has any objections, please let me know. >> >> ------------------ >> >> From: Kurt Borja >> >> [ Upstream commit 4f30f946f27b7f044cf8f3f1f353dee1dcd3517a ] >> >> Many error paths in tlmi_sysfs_init() lead to sysfs groups being removed >> when they were not even created. >> >> Fix this by letting the kobject core manage these groups through their >> kobj_type's defult_groups. >> >> Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms") >> Cc: stable@vger.kernel.org >> Reviewed-by: Mark Pearson >> Reviewed-by: Ilpo Järvinen >> Signed-off-by: Kurt Borja >> Link: https://lore.kernel.org/r/20250630-lmi-fix-v3-3-ce4f81c9c481@gmail.com >> Signed-off-by: Ilpo Järvinen >> Signed-off-by: Sasha Levin >> --- >> drivers/platform/x86/think-lmi.c | 35 +++++++++----------------------- >> 1 file changed, 10 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c >> index 36ff64a7b6847..cc46aa5f1da2c 100644 >> --- a/drivers/platform/x86/think-lmi.c >> +++ b/drivers/platform/x86/think-lmi.c >> @@ -491,6 +491,7 @@ static struct attribute *auth_attrs[] = { >> static const struct attribute_group auth_attr_group = { >> .attrs = auth_attrs, >> }; >> +__ATTRIBUTE_GROUPS(auth_attr); >> >> /* ---- Attributes sysfs --------------------------------------------------------- */ >> static ssize_t display_name_show(struct kobject *kobj, struct kobj_attribute *attr, >> @@ -643,6 +644,7 @@ static const struct attribute_group tlmi_attr_group = { >> .is_visible = attr_is_visible, >> .attrs = tlmi_attrs, >> }; >> +__ATTRIBUTE_GROUPS(tlmi_attr); >> >> static ssize_t tlmi_attr_show(struct kobject *kobj, struct attribute *attr, >> char *buf) >> @@ -688,12 +690,14 @@ static void tlmi_pwd_setting_release(struct kobject *kobj) >> >> static struct kobj_type tlmi_attr_setting_ktype = { >> .release = &tlmi_attr_setting_release, >> - .sysfs_ops = &tlmi_kobj_sysfs_ops, >> + .sysfs_ops = &kobj_sysfs_ops, >> + .default_groups = tlmi_attr_groups, > >I did *not* author this change and it utterly *breaks* the driver. > >This patch should be dropped ASAP. Right sorry about that - I accidently left that extra line of context you've pointed out. Dropped now along with the other patch you've pointed out. -- Thanks, Sasha