Re: [PATCH v4 3/3] drm/i915/psr: Add enable_panel_replay module parameter

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Jul 15, 2025 at 01:55:09PM +0300, Jouni Högander wrote:
> Add new module parameter enable_panel_replay. This can be used to
> enable/disable Panel Replay. 0=disabled, 1=enabled. -1=use per-chip default
> (default).
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
>  drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
>  drivers/gpu/drm/i915/display/intel_psr.c            | 5 ++++-
>  3 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
> index 75316247ee8a..2aed110c5b09 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.c
> @@ -120,6 +120,9 @@ intel_display_param_named_unsafe(enable_psr, int, 0400,
>  	"(0=disabled, 1=enable up to PSR1, 2=enable up to PSR2) "
>  	"Default: -1 (use per-chip default)");
>  
> +intel_display_param_named_unsafe(enable_panel_replay, int, 0400,
> +	"Enable Panel Replay (0=disabled, 1=enabled). Default: -1 (use per-chip default)");
> +
>  intel_display_param_named(psr_safest_params, bool, 0400,
>  	"Replace PSR VBT parameters by the safest and not optimal ones. This "
>  	"is helpful to detect if PSR issues are related to bad values set in "
> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
> index 784e6bae8615..b01bc5700c52 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.h
> @@ -46,6 +46,7 @@ struct drm_printer;
>  	param(bool, enable_dp_mst, true, 0600) \
>  	param(int, enable_fbc, -1, 0600) \
>  	param(int, enable_psr, -1, 0600) \
> +	param(int, enable_panel_replay, -1, 0600) \
>  	param(bool, psr_safest_params, false, 0400) \
>  	param(bool, enable_psr2_sel_fetch, true, 0400) \
>  	param(int, enable_dmc_wl, -1, 0400) \
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index ee1f9a240283..6bd3454bb00e 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -259,7 +259,10 @@ static bool sel_update_global_enabled(struct intel_dp *intel_dp)
>  
>  static bool panel_replay_global_enabled(struct intel_dp *intel_dp)
>  {
> -	return !(intel_dp->psr.debug & I915_PSR_DEBUG_PANEL_REPLAY_DISABLE);
> +	struct intel_display *display = to_intel_display(intel_dp);
> +
> +	return !(intel_dp->psr.debug & I915_PSR_DEBUG_PANEL_REPLAY_DISABLE) &&
> +		display->params.enable_panel_replay;
>  }
>  
>  static u32 psr_irq_psr_error_bit_get(struct intel_dp *intel_dp)
> -- 
> 2.43.0
>