All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Remi Buisson <Remi.Buisson@tdk.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/8] iio: imu: inv_icm45600: add new inv_icm45600 driver
Date: Wed, 16 Jul 2025 12:25:59 +0300	[thread overview]
Message-ID: <aHdwJ--tK4ANBlT4@smile.fi.intel.com> (raw)
In-Reply-To: <FR2PPF4571F02BC1A8F6E7F098A498E0B9C8C57A@FR2PPF4571F02BC.DEUP281.PROD.OUTLOOK.COM>

On Tue, Jul 15, 2025 at 03:26:48PM +0000, Remi Buisson wrote:
> >From: Andy Shevchenko <andriy.shevchenko@intel.com> 
> >Sent: Tuesday, July 15, 2025 12:43 PM
> >On Tue, Jul 15, 2025 at 09:11:47AM +0000, Remi Buisson wrote:
> >> >From: Andy Shevchenko <andriy.shevchenko@intel.com> 
> >> >Sent: Friday, July 11, 2025 1:56 PM
> >> >On Fri, Jul 11, 2025 at 11:32:48AM +0000, Remi Buisson wrote:
> >> >> >From: Andy Shevchenko andriy.shevchenko@intel.com<mailto:andriy.shevchenko@intel.com>
> >> >> >Sent: Thursday, July 10, 2025 11:30 AM
> >> >> >On Thu, Jul 10, 2025 at 08:57:57AM +0000, Remi Buisson via B4 Relay wrote:

...

> >> >> It's probably safer to keep the delay even in case of failure to make sure
> >> >> the device is ready before next operation.
> >> >
> >> >I am not sure about it. Why? This has to be well justified as it's quite
> >> >unusual pattern.
> >
> >> Ok I understand, the hardware needs that delay if the access was actually
> >> done on the bus (to not jeopardize next access).  If a regmap error means
> >> that no real access occured then the delay is avoidable.
> >
> >Perhaps you need to have this delay embedded in the IO accessors? Also do
> >read _and_ write need this or only one of them?

> It's required for both indirect read and write BUT not when writing the first data
> which need to be done in a single burst.
> Could you please be more specific on how to add delays to IO accessors?

I don't remember if regmap core supports already such a delay, but always
working case is to redefine your own regmap_read()/regmap_write() callbacks.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-07-16  9:26 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10  8:57 [PATCH v2 0/8] iio: imu: new inv_icm45600 driver Remi Buisson
2025-07-10  8:57 ` Remi Buisson via B4 Relay
2025-07-10  8:57 ` [PATCH v2 1/8] dt-bindings: iio: imu: Add inv_icm45600 Remi Buisson
2025-07-10  8:57   ` Remi Buisson via B4 Relay
2025-07-10 22:41   ` Rob Herring
2025-07-11 11:40     ` Remi Buisson
2025-07-14  5:38   ` Krzysztof Kozlowski
2025-07-15  8:35     ` Remi Buisson
2025-07-15 12:16       ` Krzysztof Kozlowski
2025-07-16 14:31         ` Remi Buisson
2025-08-19 10:19     ` Remi Buisson
     [not found]     ` <FR2PPF4571F02BC2C08BFD80F57AC4F45AA8C30A@FR2PPF4571F02BC.DEUP281.PROD.OUTLOOK.COM>
2025-08-19 14:28       ` Krzysztof Kozlowski
2025-08-19 14:53         ` Remi Buisson
2025-07-10  8:57 ` [PATCH v2 2/8] iio: imu: inv_icm45600: add new inv_icm45600 driver Remi Buisson
2025-07-10  8:57   ` Remi Buisson via B4 Relay
2025-07-10  9:29   ` Andy Shevchenko
2025-07-11 11:39     ` Remi Buisson
     [not found]     ` <FR2PPF4571F02BC5366477EC02E9C44041A8C4BA@FR2PPF4571F02BC.DEUP281.PROD.OUTLOOK.COM>
2025-07-11 11:55       ` Andy Shevchenko
2025-07-15  9:11         ` Remi Buisson
2025-07-15 10:42           ` Andy Shevchenko
2025-07-15 15:26             ` Remi Buisson
2025-07-16  9:25               ` Andy Shevchenko [this message]
2025-07-11  2:58   ` kernel test robot
2025-07-13 16:00   ` Jonathan Cameron
2025-07-15  9:33     ` Remi Buisson
2025-07-10  8:57 ` [PATCH v2 3/8] iio: imu: inv_icm45600: add buffer support in iio devices Remi Buisson
2025-07-10  8:57   ` Remi Buisson via B4 Relay
2025-07-17 14:33   ` Jonathan Cameron
2025-08-11 14:13     ` Remi Buisson
2025-08-16 11:17       ` Jonathan Cameron
2025-08-20 13:34         ` Remi Buisson
2025-07-10  8:57 ` [PATCH v2 4/8] iio: imu: inv_icm45600: add IMU IIO devices Remi Buisson
2025-07-10  8:57   ` Remi Buisson via B4 Relay
2025-07-17 14:47   ` Jonathan Cameron
2025-08-11 14:56     ` Remi Buisson
2025-07-10  8:58 ` [PATCH v2 5/8] iio: imu: inv_icm45600: add I2C driver for inv_icm45600 driver Remi Buisson
2025-07-10  8:58   ` Remi Buisson via B4 Relay
2025-07-11  7:24   ` kernel test robot
2025-07-14 20:21   ` Dan Carpenter
2025-07-15  8:09     ` Andy Shevchenko
2025-07-15  9:17     ` Remi Buisson
2025-07-10  8:58 ` [PATCH v2 6/8] iio: imu: inv_icm45600: add SPI " Remi Buisson
2025-07-10  8:58   ` Remi Buisson via B4 Relay
2025-07-11  4:55   ` kernel test robot
2025-07-11  6:09     ` Andy Shevchenko
2025-07-15  9:18       ` Remi Buisson
2025-07-10  8:58 ` [PATCH v2 7/8] iio: imu: inv_icm45600: add I3C " Remi Buisson
2025-07-10  8:58   ` Remi Buisson via B4 Relay
2025-07-14 12:56   ` Sean Nyekjaer
2025-07-15  8:48     ` Remi Buisson
2025-07-10  8:58 ` [PATCH v2 8/8] MAINTAINERS: add entry for inv_icm45600 6-axis imu sensor Remi Buisson
2025-07-10  8:58   ` Remi Buisson via B4 Relay
2025-07-14 12:06 ` [PATCH v2 0/8] iio: imu: new inv_icm45600 driver Sean Nyekjaer
2025-07-15  9:03   ` Remi Buisson
2025-07-15  9:18     ` Sean Nyekjaer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHdwJ--tK4ANBlT4@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=Remi.Buisson@tdk.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.