From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 093D4C83F1B for ; Wed, 16 Jul 2025 16:09:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l+/60hQH21ScCJ5V3seUb23tdkH82QxhbAQVKUwaaho=; b=idcLc8berh5WYl gSwis4EM6EDvT27+Ap/pJaaY4otvzeIwkzpT7t9Jkvp/Se+wM7AUwF98BSQVkV9qlMluywoqCZ1TK X8raVDITB9HaF1qP11c/Bmuok+EnOLMDyaOHDYkxQBo9ubnuVBsUe5bPcbqDD3jdFVu+9qfaop5GV 0Ai1vkzOf740yMeM9tKKPlaL0vWZoHFzACUJuwOTcxUGfp32axQQ+Ni/pXHbK4ndoLyyvlIsLnLSJ dd+tMQ7lIS5pGMFROFdxeQgx2oWfuZIRnHBYPBdtwrrRgk5nYvVuu38ujuPr6tx+JI7dh4VIzFWUD ahRaJHBH2VBkAcVZ2V9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uc4gg-000000089FM-1p8y; Wed, 16 Jul 2025 16:08:54 +0000 Received: from layka.disroot.org ([178.21.23.139]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uc4gc-000000089Dh-20X6 for linux-riscv@lists.infradead.org; Wed, 16 Jul 2025 16:08:52 +0000 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DB969204E5; Wed, 16 Jul 2025 18:08:45 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zWVEH2PJBuQV; Wed, 16 Jul 2025 18:08:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1752682123; bh=+W09G+Txez91PG0u3dbICXsTHJsZszmOf0ugQkIaaeA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GdtmVZFDjG0lz+7Huklm4/jycmaVtH67HDQs5AJa6TZfEKTzBpnruRYP9bAtsf0EW +rDkAfYaf0HwfeMI2vlLQMKoa0PHcAZbQKmWmG/I+obofupMI1Tv8wyDciVq1FVCtS umMxZpEoGfqsYPsJKsqSXOMJmqYFtSKxR8ta97N3fwk/dwzsC+G7ylqFyeZfxsvBCT pLoDvLEf5o69RTrQX34aKiGe4D20GSLZUdeFMC39/uaFuKB31tdMctt7ARCBLQrblC 1T46W4yCEc53FFQu7dpeymOgxG+Nld0G4khR9DiIJwxo7U8LW7QYqJ/fhQxosXBjL7 oVKVE2hh1S63g== Date: Wed, 16 Jul 2025 16:08:26 +0000 From: Yao Zi To: E Shattow , Icenowy Zheng , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Jisheng Zhang , Michael Zhu , Drew Fustini Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] riscv: dts: starfive: add DT for Orange Pi RV Message-ID: References: <20250409091801.855083-1-uwu@icenowy.me> <20250409091801.855083-2-uwu@icenowy.me> <8fbd6ffdd053760b6d0980173c7f8af6c09963ba.camel@icenowy.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250716_090851_075043_5A2DC2FC X-CRM114-Status: GOOD ( 39.87 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdWwgMTUsIDIwMjUgYXQgMDY6MzA6NTdQTSAtMDcwMCwgRSBTaGF0dG93IHdyb3Rl Ogo+IE9uIDQvMTAvMjUgMTg6MjksIEljZW5vd3kgWmhlbmcgd3JvdGU6Cj4gPiDlnKggMjAyNS0w NC0xMOaYn+acn+Wbm+eahCAxNjo1NCArMDAwMO+8jFlhbyBaaeWGmemBk++8mgo+ID4+IE9uIFdl ZCwgQXByIDA5LCAyMDI1IGF0IDA1OjE4OjAxUE0gKzA4MDAsIEljZW5vd3kgWmhlbmcgd3JvdGU6 Cj4gPj4+IE9yYW5nZSBQaSBSViBpcyBhIG5ld2x5IHJlbGVhc2VkIFNCQyB3aXRoIEpINzExMCBT b0MsIHNpbmdsZSBHYkUKPiA+Pj4gcG9ydAo+ID4+PiAoY29ubmVjdGVkIHRvIEpINzExMCBHTUFD MCB2aWEgYSBZVDg1MzEgUEhZKSwgNCBVU0IgcG9ydHMgKHZpYSBhCj4gPj4+IFZMODA1Cj4gPj4+ IFBDSWUgVVNCIGNvbnRyb2xsZXIgY29ubmVjdGVkIHRvIEpINzExMCBQQ0lFMCksIGEgTS4yIE0t a2V5IHNsb3QKPiA+Pj4gKGNvbm5lY3RlZCB0byBKSDcxMTAgUENJRTEpLCBhIEhETUkgdmlkZW8g b3V0cHV0LCBhIDMuNW1tIGF1ZGlvCj4gPj4+IG91dHB1dAo+ID4+PiBhbmQgYSBtaWNyb1NEIHNs b3QuCj4gPj4+Cj4gPj4+IE9uYm9hcmQgcGVyaXBoZXJhbHMgY29udGFpbiBhIFNQSSBOT1IgKHdo aWNoIGNvbnRhaW5zIHRoZSBVLUJvb3QKPiA+Pj4gZmlybXdhcmUpIGFuZCBhbiBBbXBhayBBUDYy NTYgU0RJTyBXaS1GaSBtb2R1bGUuCj4gPj4+Cj4gPj4+IEFzIHRoZSBzY2hlbWF0aWNzIGlzbid0 IGF2YWlsYWJsZSB5ZXQsIHRoZSBTRElPIFdpLUZpIGlzIGxlZnQKPiA+Pj4gZGlzYWJsZWQKPiA+ Pj4geWV0Lgo+ID4+Pgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBJY2Vub3d5IFpoZW5nIDx1d3VAaWNl bm93eS5tZT4KPiA+Pj4gLS0tCj4gPj4+IMKgYXJjaC9yaXNjdi9ib290L2R0cy9zdGFyZml2ZS9N YWtlZmlsZcKgwqDCoMKgwqDCoMKgwqAgfMKgIDEgKwo+ID4+PiDCoC4uLi9ib290L2R0cy9zdGFy Zml2ZS9qaDcxMTAtb3JhbmdlcGktcnYuZHRzwqAgfCA3Mwo+ID4+PiArKysrKysrKysrKysrKysr KysrCj4gPj4+IMKgMiBmaWxlcyBjaGFuZ2VkLCA3NCBpbnNlcnRpb25zKCspCj4gPj4+IMKgY3Jl YXRlIG1vZGUgMTAwNjQ0IGFyY2gvcmlzY3YvYm9vdC9kdHMvc3RhcmZpdmUvamg3MTEwLW9yYW5n ZXBpLQo+ID4+PiBydi5kdHMKPiA+Pj4KPiA+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3YvYm9v dC9kdHMvc3RhcmZpdmUvTWFrZWZpbGUKPiA+Pj4gYi9hcmNoL3Jpc2N2L2Jvb3QvZHRzL3N0YXJm aXZlL01ha2VmaWxlCj4gPj4+IGluZGV4IGIzYmIxMmY3OGU3ZDUuLjI0ZjFhNDQ4MjgzNTAgMTAw NjQ0Cj4gPj4+IC0tLSBhL2FyY2gvcmlzY3YvYm9vdC9kdHMvc3RhcmZpdmUvTWFrZWZpbGUKPiA+ Pj4gKysrIGIvYXJjaC9yaXNjdi9ib290L2R0cy9zdGFyZml2ZS9NYWtlZmlsZQo+ID4+PiBAQCAt MTAsNiArMTAsNyBAQCBkdGItJChDT05GSUdfQVJDSF9TVEFSRklWRSkgKz0gamg3MTAwLXN0YXJm aXZlLQo+ID4+PiB2aXNpb25maXZlLXYxLmR0Ygo+ID4+PiDCoAo+ID4+PiDCoGR0Yi0kKENPTkZJ R19BUkNIX1NUQVJGSVZFKSArPSBqaDcxMTAtZGVlcGNvbXB1dGluZy1mbWwxM3YwMS5kdGIKPiA+ Pj4gwqBkdGItJChDT05GSUdfQVJDSF9TVEFSRklWRSkgKz0gamg3MTEwLW1pbGt2LW1hcnMuZHRi Cj4gPj4+ICtkdGItJChDT05GSUdfQVJDSF9TVEFSRklWRSkgKz0gamg3MTEwLW9yYW5nZXBpLXJ2 LmR0Ygo+ID4+PiDCoGR0Yi0kKENPTkZJR19BUkNIX1NUQVJGSVZFKSArPSBqaDcxMTAtcGluZTY0 LXN0YXI2NC5kdGIKPiA+Pj4gwqBkdGItJChDT05GSUdfQVJDSF9TVEFSRklWRSkgKz0gamg3MTEw LXN0YXJmaXZlLXZpc2lvbmZpdmUtMi0KPiA+Pj4gdjEuMmEuZHRiCj4gPj4+IMKgZHRiLSQoQ09O RklHX0FSQ0hfU1RBUkZJVkUpICs9IGpoNzExMC1zdGFyZml2ZS12aXNpb25maXZlLTItCj4gPj4+ IHYxLjNiLmR0Ygo+ID4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9yaXNjdi9ib290L2R0cy9zdGFyZml2 ZS9qaDcxMTAtb3JhbmdlcGktcnYuZHRzCj4gPj4+IGIvYXJjaC9yaXNjdi9ib290L2R0cy9zdGFy Zml2ZS9qaDcxMTAtb3JhbmdlcGktcnYuZHRzCj4gPj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4g Pj4+IGluZGV4IDAwMDAwMDAwMDAwMDAuLmJkZTAxZjExN2UwYjIKPiA+Pj4gLS0tIC9kZXYvbnVs bAo+ID4+PiArKysgYi9hcmNoL3Jpc2N2L2Jvb3QvZHRzL3N0YXJmaXZlL2poNzExMC1vcmFuZ2Vw aS1ydi5kdHMKPiA+Pj4gQEAgLTAsMCArMSw3MyBAQAo+ID4+PiArLy8gU1BEWC1MaWNlbnNlLUlk ZW50aWZpZXI6IEdQTC0yLjAgT1IgTUlUCj4gPj4+ICsvKgo+ID4+PiArICogQ29weXJpZ2h0IChD KSAyMDI1IEljZW5vd3kgWmhlbmcgPHV3dUBpY2Vub3d5Lm1lPgo+ID4+PiArICovCj4gPj4+ICsK PiA+Pj4gKy9kdHMtdjEvOwo+ID4+PiArI2luY2x1ZGUgImpoNzExMC1jb21tb24uZHRzaSIKPiA+ Pj4gKyNpbmNsdWRlIDxkdC1iaW5kaW5ncy9sZWRzL2NvbW1vbi5oPgo+ID4+PiArCj4gPj4+ICsv IHsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgbW9kZWwgPSAiWHVubG9uZyBPcmFuZ2UgUGkgUlYiOwo+ ID4+PiArwqDCoMKgwqDCoMKgwqBjb21wYXRpYmxlID0gInh1bmxvbmcsb3JhbmdlcGktcnYiLCAi c3RhcmZpdmUsamg3MTEwIjsKPiA+Pj4gKwo+ID4+PiArwqDCoMKgwqDCoMKgwqBsZWRzIHsKPiA+ Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGNvbXBhdGlibGUgPSAiZ3Bpby1sZWRz IjsKPiA+Pj4gKwo+ID4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgbGVkLWFjayB7 Cj4gPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZ3Bp b3MgPSA8JmFvbmdwaW8gMyBHUElPX0FDVElWRV9ISUdIPjsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBjb2xvciA9IDxMRURfQ09MT1JfSURfR1JF RU4+Owo+ID4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oGZ1bmN0aW9uID0gTEVEX0ZVTkNUSU9OX0hFQVJUQkVBVDsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBsaW51eCxkZWZhdWx0LXRyaWdnZXIgPSAi aGVhcnRiZWF0IjsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqBsYWJlbCA9ICJhY2siOwo+ID4+Cj4gPj4gU2hvdWxkIHdlIHNvcnQgdGhlIHByb3Bl cnRpZXMgaW4gYWxwaGFiZXQgb3JkZXI/IGkuZS4gY29sb3IsCj4gPj4gZnVuY3Rpb24sCj4gPj4g Z3Bpb3MsIGxhYmVsIHRoZW4gbGludXgsZGVmYXVsdC10cmlnZ2VyLiBTZWUgZHRzLWNvZGluZy1z dHlsZS5yc3QsCj4gPiAKPiA+IFdlbGwgaW4gY2FzZSBvZiBHUElPIExFRCwgSSB0aGluayBncGlv cyBpcyBzb21ldGhpbmcgbGlrZSByZWc/IEFsdGhvdWdoCj4gPiB0aGlzIGlzIG9ubHkgbXkgcGVy c29uYWwgZmVlbCwgYW5kIGxhYmVsIHJlYWxseSBuZWVkcyB0byBiZSByZW9yZGVyZWQKPiA+IHRo ZW4uCj4gPiAKPiAKPiBTdGF0dXMgbGVkIGRlc2NyaXB0aW9uIGhlcmUgZG9lcyBpbnN0ZWFkIGJl bG9uZyBpbiBqaDcxMTAtY29tbW9uLmR0c2kKPiBzaW5jZSBhbGwgdmFyaWFudCBib2FyZHMgYXJl IHVzaW5nIHRoZSBzYW1lIFJHUElPMyAoZm91cnRoIEdQSU8gb24gUE1VCj4gZG9tYWluKS4KPiAK PiA+Pgo+ID4+PiBUaGUgZm9sbG93aW5nIG9yZGVyIG9mIHByb3BlcnRpZXMgaW4gZGV2aWNlIG5v ZGVzIGlzIHByZWZlcnJlZDoKPiA+Pj4KPiA+Pj4gMS4gImNvbXBhdGlibGUiCj4gPj4+IDIuICJy ZWciCj4gPj4+IDMuICJyYW5nZXMiCj4gPj4+IDQuIFN0YW5kYXJkL2NvbW1vbiBwcm9wZXJ0aWVz IChkZWZpbmVkIGJ5IGNvbW1vbiBiaW5kaW5ncywgZS5nLgo+ID4+PiB3aXRob3V0Cj4gPj4+IHZl bmRvci1wcmVmaXhlcykKPiA+Pj4gNS4gVmVuZG9yLXNwZWNpZmljIHByb3BlcnRpZXMKPiA+Pj4g Ni4gInN0YXR1cyIgKGlmIGFwcGxpY2FibGUpCj4gPj4+IDcuIENoaWxkIG5vZGVzLCB3aGVyZSBl YWNoIG5vZGUgaXMgcHJlY2VkZWQgd2l0aCBhIGJsYW5rIGxpbmUKPiA+Pgo+ID4+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfTsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgfTsKPiA+Pj4g K307Cj4gPj4+ICsKPiA+Pj4gKyZnbWFjMCB7Cj4gPj4+ICvCoMKgwqDCoMKgwqDCoHN0YXJmaXZl LHR4LXVzZS1yZ21paS1jbGs7Cj4gPj4+ICvCoMKgwqDCoMKgwqDCoGFzc2lnbmVkLWNsb2NrcyA9 IDwmYW9uY3JnIEpINzExMF9BT05DTEtfR01BQzBfVFg+Owo+ID4+PiArwqDCoMKgwqDCoMKgwqBh c3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZhb25jcmcKPiA+Pj4gSkg3MTEwX0FPTkNMS19HTUFD MF9STUlJX1JUWD47Cj4gPj4+ICvCoMKgwqDCoMKgwqDCoHN0YXR1cyA9ICJva2F5IjsKPiA+Pgo+ ID4+IFZlbmRvciBwcm9wZXJ0eSBzdGFyZml2ZSx0eC11c2UtcmdtaWktY2xrIHNob3VsZCBnbyBh ZnRlciB0aGUgY29tbW9uCj4gPj4gb25lcy4KPiA+IAo+ID4gT2theSwgSSB3aWxsIGZpeCB0aGlz IChhbmQgdGhlIG9uZSBiZWxvdykgaW4gbmV4dCByZXZpc2lvbi4KPiA+IAo+ID4gVGhhbmtzLAo+ ID4gSWNlbm93eQo+IAo+IFdlbGwgdGhlbiBkb2VzIHRoZSBkb2N1bWVudGF0aW9uIGZvbGxvdyBy ZWNvbW1lbmRlZCBzb3J0IG9yZGVyaW5nPwo+IAo+IGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9j L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9sZWRzL2NvbW1vbi55YW1sCgpJIGRv bid0IHRoaW5rIHNvLgoKPiBMb29rcyB0byBtZSBsaWtlIGl0IGlzIG5vdCBjbGVhciB3aGF0IGlz IGdvaW5nIG9uIHRoZXJlIHdpdGggc29ydAo+IG9yZGVyaW5nLiBUaGUgcmVjZW50bHkgYWNjZXB0 ZWQgZHRzIGluLXRyZWUgYXJlIGEgbWl4IG9mICJ3aG8gY2FyZXM/IiwKPiBhbHBoYWJldCBzb3J0 LCBhbmQgcHJlZmVyZW50aWFsbHkgYnV0IGFyYml0cmFyaWx5IHBsYWNpbmcgc29tZSB0aGluZ3MK PiBhYm92ZSBvdGhlcnMuIFRoZSBkb2N1bWVudGF0aW9uIGlzIGV2ZW4gZGlmZmVyZW50IHRoYW4g YWxsIHRoYXQuCj4gCj4gTWF5YmUgaWYgdGhlIGRvY3VtZW50YXRpb24gc2hvdWxkIGJlIGZvbGxv d2VkIHdlIHNob3VsZCBmb2xsb3cgaXQsIGVsc2UKPiBmaXggdGhlIGRvY3VtZW50YXRpb24gZmly c3RseS4KCkJhc2ljYWxseSBhZ3JlZSBoZXJlLCB0aGUgInNvcnQgYnkgYWxwaGFiZXRpY2FsIG9y ZGVyIiByZXF1aXJlbWVudAooZGVzY3JpYmVkIGhlcmVbMV0pIGRvZXNuJ3Qgc2VlbSB0byBwbGF5 IHdlbGwgaW4gYWxsIGNhc2VzOiB3aGF0IEljZW5vd3kKY2xhaW1lZCBzb3VuZHMgcmVhc29uYWJs ZSB0byBtZSBhbmQgbG9va3MgbW9yZSBuYXR1cmFsIHRoYW4gdGhlIGdlbmVyYWwKcnVsZS4gU28g bWF5YmUgd2Ugc2hvdWxkICJvdmVycmlkZSIgdGhlIHJ1bGUgaW4gc3Vic3lzdGVtLXNwZWNpZmlj CmJpbmRpbmdzLiBJIHN1Z2dlc3QgcmFpc2luZyBhIGZvcm1hbCBkaXNjdXNzaW9uIGFib3V0IGxl ZHMvY29tbW9uLnlhbWwKYW5kIHNlZSB3aGV0aGVyIHRoaXMgY291bGQgbGFuZCBmb3JtYWxseSBp biB0aGUgbGVkJ3MgYmluZGluZywgYW5kIEknbQp3aWxsaW5nIHRvIGRvIHNvLgoKRnV0aGVybW9y ZSwgc2ltaWxhciBvcmRlciBpc3N1ZXMgZG9uJ3Qgb25seSBvY2N1ciBpbiB0aGUgTEVEIGJpbmRp bmcsCmJ1dCBhbHNvLCBmb3IgZXhhbXBsZSwgdGhlIHBpbmN0cmwgc3R1ZmYuIEluIHRoZSBleGFt cGxlIG9mCnBpbmN0cmwtYmluZGluZy50eHRbMl0sIHBpbmN0cmwtbmFtZXMgYWx3YXlzIGdvZXMg YmVmb3JlIHBpbmN0cmwtWzAtOV0qLAp3aGljaCBkb2Vzbid0IGZvbGxvdyB0aGUgZ2VuZXJhbCBy dWxlIGFzIHdlbGwsIGFuZCB3ZSBjb3VsZCBzZWUgdGhlCm9wcG9zaXRlIGlzIGFsc28gcG9wcHVs YXIgaW4gdGhlIGFjY2VwdGVkIGRldmljZXRyZWVzLiBUaGlzIHNob3VsZCBiZQpjbGFyaWZpZWQs IHRvby4KCj4gPiAKPiA+Pj4gK307Cj4gPj4+ICsKPiA+Pj4gKyZpMmMwIHsKPiA+Pj4gK8KgwqDC oMKgwqDCoMKgc3RhdHVzID0gIm9rYXkiOwo+ID4+PiArfTsKPiA+Pj4gKwo+ID4+PiArJm1tYzAg ewo+ID4+PiArwqDCoMKgwqDCoMKgwqAvKiBUT0RPOiBBbXBhayBBUDYyNTYgV2ktRmkgbW9kdWxl IGF0dGFjaGVkIGhlcmUgKi8KPiA+Pj4gK8KgwqDCoMKgwqDCoMKgc3RhdHVzID0gImRpc2FibGVk IjsKPiA+Pj4gK307Cj4gCj4gT3JhbmdlIFBpIFJWIHNjaGVtYXRpYyBpcyBwdWJsaXNoZWQgbm93 LiBQbGVhc2UgaW1wbGVtZW50IHRoaXMKPiBkZXNjcmlwdGlvbiBoZXJlLgo+IAo+IFlvdSBtYXkg YWxzbyB3aXNoIHRvIHJldmlldyB0aGUgU3RhckZpdmUgSkg3MTAwIGRldmljZXRyZWUgZGVzY3Jp cHRpb25zCj4gKGFuZCBzY2hlbWF0aWMpLCBhbmQgYWRkaXRpb25hbGx5IHRoZSBwdWJsaXNoZWQg TWlsay1WIE1hcnMgQ00gLyBNYXJzIENNCj4gTGl0ZSBzY2hlbWF0aWMsIGZvciBjbHVlcyBhYm91 dCBBUDYyNTYuIFRoZSByZXF1aXJlZCBmaXJtd2FyZSBmaWxlcycKPiBpbnRlbGxlY3R1YWwgcHJv cGVydHkgd2hlbiBkdXJpbmcgdGhlIGxhc3QgZGlzY3Vzc2lvbiBhYm91dAo+IGxpbnV4LWZpcm13 YXJlIHdhcyBkZXRlcm1pbmVkIHRvIGJlIFN5bmFwdGljcyAobGFiZWxlZCBhcyBCcm9hZGNvbW0p IGFuZAo+IHJlamVjdGVkIGZyb20gaW5jbHVzaW9uIGR1ZSB0byBubyBjbGVhciBsaWNlbnNlZCBw ZXJtaXNzaW9uIGZvcgo+IGRpc3RyaWJ1dGlvbi4gTWF5YmUgaXQgaXMgdGltZSB0byByZXZpc2l0 IHRoaXMgYW5kIGZpbmQgc29tZW9uZSB3aWxsaW5nCj4gdG8gZG8gdGhlIHdvcmsgb2YgcmVzb2x2 aW5nIHRoZSBsaWNlbnNlIGFtYmlndWl0eT8KPiAKPiA+Pj4gKwo+ID4+PiArJm1tYzEgewo+ID4+ PiArwqDCoMKgwqDCoMKgwqAvZGVsZXRlLXByb3BlcnR5LyBjZC1ncGlvczsKPiA+Pj4gK8KgwqDC oMKgwqDCoMKgYnJva2VuLWNkOwo+ID4+PiArfTsKPiA+Pj4gKwo+ID4+PiArJnBjaWUwIHsKPiA+ Pj4gK8KgwqDCoMKgwqDCoMKgc3RhdHVzID0gIm9rYXkiOwo+ID4+PiArfTsKPiA+Pj4gKwo+ID4+ PiArJnBjaWUxIHsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgc3RhdHVzID0gIm9rYXkiOwo+ID4+PiAr fTsKPiA+Pj4gKwo+ID4+PiArJnBoeTAgewo+ID4+PiArwqDCoMKgwqDCoMKgwqBtb3RvcmNvbW0s dHgtY2xrLWFkai1lbmFibGVkOwo+ID4+PiArwqDCoMKgwqDCoMKgwqBtb3RvcmNvbW0sdHgtY2xr LTEwLWludmVydGVkOwo+ID4+PiArwqDCoMKgwqDCoMKgwqBtb3RvcmNvbW0sdHgtY2xrLTEwMC1p bnZlcnRlZDsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgbW90b3Jjb21tLHR4LWNsay0xMDAwLWludmVy dGVkOwo+ID4+PiArwqDCoMKgwqDCoMKgwqBtb3RvcmNvbW0scngtY2xrLWRydi1taWNyb2FtcCA9 IDwzOTcwPjsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgbW90b3Jjb21tLHJ4LWRhdGEtZHJ2LW1pY3Jv YW1wID0gPDI5MTA+Owo+ID4+PiArwqDCoMKgwqDCoMKgwqByeC1pbnRlcm5hbC1kZWxheS1wcyA9 IDwxNTAwPjsKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgdHgtaW50ZXJuYWwtZGVsYXktcHMgPSA8MTUw MD47Cj4gPj4+ICt9Owo+ID4+Cj4gPj4gRGl0dG8sIG1vdmUgdGhlIHZlbmRvciBwcm9wZXJ0aWVz IGJlbG93IHRoZSBjb21tb24gb25lcy4KPiAKPiBZZXMgYW5kLCBvbmUgb2YgdXMgbWF5IHJldmll dyB3aGF0IGlzIGFscmVhZHkgaW4gc3RhcmZpdmUvIGR0cyB0byBmaXgKPiBhbmQgc2VuZCBhIHBh dGNoIGZvciB0aGlzIG1lc3Mgb2YgZGV2aWNldHJlZSBzb3J0IG9yZGVyLiBUaGUgaXNzdWUKPiBy ZXBlYXRzIGV2ZXJ5IHRpbWUgd2UgbG9vayBmb3IgYW4gZXhpc3Rpbmcgc2FtcGxlIHRvIHVzZS4K Ck9vcHMsIEkndmUgbmV2ZXIgZXhwZWN0ZWQgdGhhdCB0aGVyZSdyZSBzbyBtYW55IHZlbmRvci1z cGVjaWZpYwpwcm9wZXJ0aWVzIG1peGVkIHdpdGggb3RoZXJzIGluIHN0YXJmaXZlJ3MgZGV2aWNl dHJlZXMuIEknbSB3aWxsaW5nIHRvCmNsZWFuIHRoZW0gdXAgd2hlbiBhdmFpbGFibGUsIGJ1dCBm ZWVsIGZyZWUgdG8gdGFrZSB0aGUgd29yayBzaW5jZSBJJ20gYQpsaXR0bGUgYnVzeS4KCj4gPj4K PiA+Pj4gKyZwd21kYWMgewo+ID4+PiArwqDCoMKgwqDCoMKgwqBzdGF0dXMgPSAib2theSI7Cj4g Pj4+ICt9Owo+ID4+PiArCj4gPj4+ICsmc3BpMCB7Cj4gPj4+ICvCoMKgwqDCoMKgwqDCoHN0YXR1 cyA9ICJva2F5IjsKPiA+Pj4gK307Cj4gPj4+IC0tIAo+ID4+PiAyLjQ5LjAKPiA+Pj4KPiA+Pgo+ ID4+IEJlc3QgcmVnYXJkcywKPiA+PiBZYW8gWmkKPiA+IAo+IAo+IEIuUi4sICAtRSBTaGF0dG93 CgpSZWdhcmRzLApZYW8gWmkKClsxXTogaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgv djYuMTYtcmM2L3NvdXJjZS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHRzLWNv ZGluZy1zdHlsZS5yc3QjTDExNS1MMTI0ClsyXTogaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20v bGludXgvdjYuMTYtcmM2L3NvdXJjZS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv cGluY3RybC9waW5jdHJsLWJpbmRpbmdzLnR4dCNMNzQtTDk3CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGlu dXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB8202F532D; Wed, 16 Jul 2025 16:08:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752682137; cv=none; b=tFYXBNEFjjM6/Wpf6jW+YtwBy3AII0rf89bb+AdaMPPYMeQfhjqEwa4BJOG7m/TQn9t+JPyrxqCCALToHayzCL3ybAJPUec7Kd2qhOWd31rCb/FL8S8wJh4D4kTFYA9r9BNdM8o0VyD65tf/wDMqhjJ/V+YoM3e/13V/emNP1CQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752682137; c=relaxed/simple; bh=+W09G+Txez91PG0u3dbICXsTHJsZszmOf0ugQkIaaeA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RN39ykmseIVHp2acbv3JhA1DuQ2UUbpmv6uouTzqTgvuo8bILSuwCG7N4jH+O+rQIWU+iVhxlzA4d7uJKkYIRwo+lMCUWxC49t81LT+GGMVx/LXgoGLhs4OjEtNhGxkmf3NIP2hvH+p7Ot9ivXKPXLOJUamOw7e7nBrjPQQK/eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=GdtmVZFD; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="GdtmVZFD" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DB969204E5; Wed, 16 Jul 2025 18:08:45 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zWVEH2PJBuQV; Wed, 16 Jul 2025 18:08:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1752682123; bh=+W09G+Txez91PG0u3dbICXsTHJsZszmOf0ugQkIaaeA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GdtmVZFDjG0lz+7Huklm4/jycmaVtH67HDQs5AJa6TZfEKTzBpnruRYP9bAtsf0EW +rDkAfYaf0HwfeMI2vlLQMKoa0PHcAZbQKmWmG/I+obofupMI1Tv8wyDciVq1FVCtS umMxZpEoGfqsYPsJKsqSXOMJmqYFtSKxR8ta97N3fwk/dwzsC+G7ylqFyeZfxsvBCT pLoDvLEf5o69RTrQX34aKiGe4D20GSLZUdeFMC39/uaFuKB31tdMctt7ARCBLQrblC 1T46W4yCEc53FFQu7dpeymOgxG+Nld0G4khR9DiIJwxo7U8LW7QYqJ/fhQxosXBjL7 oVKVE2hh1S63g== Date: Wed, 16 Jul 2025 16:08:26 +0000 From: Yao Zi To: E Shattow , Icenowy Zheng , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Jisheng Zhang , Michael Zhu , Drew Fustini Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] riscv: dts: starfive: add DT for Orange Pi RV Message-ID: References: <20250409091801.855083-1-uwu@icenowy.me> <20250409091801.855083-2-uwu@icenowy.me> <8fbd6ffdd053760b6d0980173c7f8af6c09963ba.camel@icenowy.me> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 15, 2025 at 06:30:57PM -0700, E Shattow wrote: > On 4/10/25 18:29, Icenowy Zheng wrote: > > 在 2025-04-10星期四的 16:54 +0000，Yao Zi写道： > >> On Wed, Apr 09, 2025 at 05:18:01PM +0800, Icenowy Zheng wrote: > >>> Orange Pi RV is a newly released SBC with JH7110 SoC, single GbE > >>> port > >>> (connected to JH7110 GMAC0 via a YT8531 PHY), 4 USB ports (via a > >>> VL805 > >>> PCIe USB controller connected to JH7110 PCIE0), a M.2 M-key slot > >>> (connected to JH7110 PCIE1), a HDMI video output, a 3.5mm audio > >>> output > >>> and a microSD slot. > >>> > >>> Onboard peripherals contain a SPI NOR (which contains the U-Boot > >>> firmware) and an Ampak AP6256 SDIO Wi-Fi module. > >>> > >>> As the schematics isn't available yet, the SDIO Wi-Fi is left > >>> disabled > >>> yet. > >>> > >>> Signed-off-by: Icenowy Zheng > >>> --- > >>>  arch/riscv/boot/dts/starfive/Makefile         |  1 + > >>>  .../boot/dts/starfive/jh7110-orangepi-rv.dts  | 73 > >>> +++++++++++++++++++ > >>>  2 files changed, 74 insertions(+) > >>>  create mode 100644 arch/riscv/boot/dts/starfive/jh7110-orangepi- > >>> rv.dts > >>> > >>> diff --git a/arch/riscv/boot/dts/starfive/Makefile > >>> b/arch/riscv/boot/dts/starfive/Makefile > >>> index b3bb12f78e7d5..24f1a44828350 100644 > >>> --- a/arch/riscv/boot/dts/starfive/Makefile > >>> +++ b/arch/riscv/boot/dts/starfive/Makefile > >>> @@ -10,6 +10,7 @@ dtb-$(CONFIG_ARCH_STARFIVE) += jh7100-starfive- > >>> visionfive-v1.dtb > >>>   > >>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-deepcomputing-fml13v01.dtb > >>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-milkv-mars.dtb > >>> +dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-orangepi-rv.dtb > >>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-pine64-star64.dtb > >>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2- > >>> v1.2a.dtb > >>>  dtb-$(CONFIG_ARCH_STARFIVE) += jh7110-starfive-visionfive-2- > >>> v1.3b.dtb > >>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts > >>> b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts > >>> new file mode 100644 > >>> index 0000000000000..bde01f117e0b2 > >>> --- /dev/null > >>> +++ b/arch/riscv/boot/dts/starfive/jh7110-orangepi-rv.dts > >>> @@ -0,0 +1,73 @@ > >>> +// SPDX-License-Identifier: GPL-2.0 OR MIT > >>> +/* > >>> + * Copyright (C) 2025 Icenowy Zheng > >>> + */ > >>> + > >>> +/dts-v1/; > >>> +#include "jh7110-common.dtsi" > >>> +#include > >>> + > >>> +/ { > >>> +       model = "Xunlong Orange Pi RV"; > >>> +       compatible = "xunlong,orangepi-rv", "starfive,jh7110"; > >>> + > >>> +       leds { > >>> +               compatible = "gpio-leds"; > >>> + > >>> +               led-ack { > >>> +                       gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>; > >>> +                       color = ; > >>> +                       function = LED_FUNCTION_HEARTBEAT; > >>> +                       linux,default-trigger = "heartbeat"; > >>> +                       label = "ack"; > >> > >> Should we sort the properties in alphabet order? i.e. color, > >> function, > >> gpios, label then linux,default-trigger. See dts-coding-style.rst, > > > > Well in case of GPIO LED, I think gpios is something like reg? Although > > this is only my personal feel, and label really needs to be reordered > > then. > > > > Status led description here does instead belong in jh7110-common.dtsi > since all variant boards are using the same RGPIO3 (fourth GPIO on PMU > domain). > > >> > >>> The following order of properties in device nodes is preferred: > >>> > >>> 1. "compatible" > >>> 2. "reg" > >>> 3. "ranges" > >>> 4. Standard/common properties (defined by common bindings, e.g. > >>> without > >>> vendor-prefixes) > >>> 5. Vendor-specific properties > >>> 6. "status" (if applicable) > >>> 7. Child nodes, where each node is preceded with a blank line > >> > >>> +               }; > >>> +       }; > >>> +}; > >>> + > >>> +&gmac0 { > >>> +       starfive,tx-use-rgmii-clk; > >>> +       assigned-clocks = <&aoncrg JH7110_AONCLK_GMAC0_TX>; > >>> +       assigned-clock-parents = <&aoncrg > >>> JH7110_AONCLK_GMAC0_RMII_RTX>; > >>> +       status = "okay"; > >> > >> Vendor property starfive,tx-use-rgmii-clk should go after the common > >> ones. > > > > Okay, I will fix this (and the one below) in next revision. > > > > Thanks, > > Icenowy > > Well then does the documentation follow recommended sort ordering? > > https://www.kernel.org/doc/Documentation/devicetree/bindings/leds/common.yaml I don't think so. > Looks to me like it is not clear what is going on there with sort > ordering. The recently accepted dts in-tree are a mix of "who cares?", > alphabet sort, and preferentially but arbitrarily placing some things > above others. The documentation is even different than all that. > > Maybe if the documentation should be followed we should follow it, else > fix the documentation firstly. Basically agree here, the "sort by alphabetical order" requirement (described here[1]) doesn't seem to play well in all cases: what Icenowy claimed sounds reasonable to me and looks more natural than the general rule. So maybe we should "override" the rule in subsystem-specific bindings. I suggest raising a formal discussion about leds/common.yaml and see whether this could land formally in the led's binding, and I'm willing to do so. Futhermore, similar order issues don't only occur in the LED binding, but also, for example, the pinctrl stuff. In the example of pinctrl-binding.txt[2], pinctrl-names always goes before pinctrl-[0-9]*, which doesn't follow the general rule as well, and we could see the opposite is also poppular in the accepted devicetrees. This should be clarified, too. > > > >>> +}; > >>> + > >>> +&i2c0 { > >>> +       status = "okay"; > >>> +}; > >>> + > >>> +&mmc0 { > >>> +       /* TODO: Ampak AP6256 Wi-Fi module attached here */ > >>> +       status = "disabled"; > >>> +}; > > Orange Pi RV schematic is published now. Please implement this > description here. > > You may also wish to review the StarFive JH7100 devicetree descriptions > (and schematic), and additionally the published Milk-V Mars CM / Mars CM > Lite schematic, for clues about AP6256. The required firmware files' > intellectual property when during the last discussion about > linux-firmware was determined to be Synaptics (labeled as Broadcomm) and > rejected from inclusion due to no clear licensed permission for > distribution. Maybe it is time to revisit this and find someone willing > to do the work of resolving the license ambiguity? > > >>> + > >>> +&mmc1 { > >>> +       /delete-property/ cd-gpios; > >>> +       broken-cd; > >>> +}; > >>> + > >>> +&pcie0 { > >>> +       status = "okay"; > >>> +}; > >>> + > >>> +&pcie1 { > >>> +       status = "okay"; > >>> +}; > >>> + > >>> +&phy0 { > >>> +       motorcomm,tx-clk-adj-enabled; > >>> +       motorcomm,tx-clk-10-inverted; > >>> +       motorcomm,tx-clk-100-inverted; > >>> +       motorcomm,tx-clk-1000-inverted; > >>> +       motorcomm,rx-clk-drv-microamp = <3970>; > >>> +       motorcomm,rx-data-drv-microamp = <2910>; > >>> +       rx-internal-delay-ps = <1500>; > >>> +       tx-internal-delay-ps = <1500>; > >>> +}; > >> > >> Ditto, move the vendor properties below the common ones. > > Yes and, one of us may review what is already in starfive/ dts to fix > and send a patch for this mess of devicetree sort order. The issue > repeats every time we look for an existing sample to use. Oops, I've never expected that there're so many vendor-specific properties mixed with others in starfive's devicetrees. I'm willing to clean them up when available, but feel free to take the work since I'm a little busy. > >> > >>> +&pwmdac { > >>> +       status = "okay"; > >>> +}; > >>> + > >>> +&spi0 { > >>> +       status = "okay"; > >>> +}; > >>> -- > >>> 2.49.0 > >>> > >> > >> Best regards, > >> Yao Zi > > > > B.R., -E Shattow Regards, Yao Zi [1]: https://elixir.bootlin.com/linux/v6.16-rc6/source/Documentation/devicetree/bindings/dts-coding-style.rst#L115-L124 [2]: https://elixir.bootlin.com/linux/v6.16-rc6/source/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt#L74-L97