Re: [PATCH 0/4] mips: CMOS RTC refactoring

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Sun, Jul 13, 2025 at 12:04:30PM +0200, Mateusz Jończyk wrote:
> Hello,
> 
> A while ago I wrote some patches that refactor a bit the RTC CMOS support on the
> MIPS architecture. These were in response to a bug report about locking
> problems during suspend / resume:
> 
> Link: https://lore.kernel.org/all/CAP-bSRZ0CWyZZsMtx046YV8L28LhY0fson2g4EqcwRAVN1Jk+Q@mail.gmail.com/
> 
> Back then, I was trying to convert the rtc_lock to a raw spinlock. This proved
> to be unnecessary and harmful, but in the process I removed some dead and
> duplicated code that touches the MC146818 (the chip of the CMOS RTC) for
> the MIPS architecture.
> 
> These patches were tested only in an emulator, as I don't have the hardware.
> They are roughly in the order of increasing risk.
> 
> Greetings,
> Mateusz
> 
> Mateusz Jończyk (4):
>   mips: remove unused function mc146818_set_rtc_mmss
>   mips/mach-rm: remove custom mc146818rtc.h file
>   mips: remove redundant macro mc146818_decode_year
>   mips/malta,loongson2ef: use generic mc146818_get_time function
> 
>  arch/mips/Kconfig                             |   2 +
>  .../include/asm/mach-generic/mc146818rtc.h    |   4 -
>  arch/mips/include/asm/mach-jazz/mc146818rtc.h |   2 -
>  .../mips/include/asm/mach-malta/mc146818rtc.h |   2 -
>  arch/mips/include/asm/mach-rm/mc146818rtc.h   |  21 ----
>  arch/mips/include/asm/mc146818-time.h         | 105 ++----------------
>  6 files changed, 9 insertions(+), 127 deletions(-)
>  delete mode 100644 arch/mips/include/asm/mach-rm/mc146818rtc.h
> 
> 
> base-commit: d7b8f8e20813f0179d8ef519541a3527e7661d3a
> -- 
> 2.25.1

series applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]