From: Brian Norris <briannorris@chromium.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/pwrctrl: Only destroy alongside host bridge
Date: Wed, 16 Jul 2025 15:25:18 -0700 [thread overview]
Message-ID: <aHgmzpNzMTL2alhp@google.com> (raw)
In-Reply-To: <aHfXrT_rU0JAjnVD@google.com>
On Wed, Jul 16, 2025 at 09:47:41AM -0700, Brian Norris wrote:
> (2) Even after resolving 1, I'm seeing pci_free_host_bridge() exit with
> a bridge->dev.kboj.kref refcount of 1 in some cases. I don't yet
> have an explanation of that one.
Ah, well now I have an explanation:
One should always be skeptical of out-of-tree drivers.
In this case, one of my endpoint drivers was mismanaging a pci_dev_put()
reference count, and that cascades to all its children and links,
including the host bridge.
Once I fix that (and the aforementioned problem (1)), it seems my
problems go away.
I'll let a v2 soak in my local environment, and unless I hear some news
from Bartosz about OF_POPULATED to change my mind, I'll send it out
eventually.
Brian
next prev parent reply other threads:[~2025-07-16 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 0:43 [PATCH] PCI/pwrctrl: Only destroy alongside host bridge Brian Norris
2025-07-12 17:26 ` Manivannan Sadhasivam
2025-07-15 21:21 ` Brian Norris
2025-07-16 15:57 ` Manivannan Sadhasivam
2025-07-16 16:47 ` Brian Norris
2025-07-16 22:25 ` Brian Norris [this message]
2025-07-17 19:20 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHgmzpNzMTL2alhp@google.com \
--to=briannorris@chromium.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.