Re: [PATCH 4/4] qga: Add cross-references

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jul 17, 2025 at 10:21:17AM +0200, Markus Armbruster wrote:
> Enclose command and type names in `backquotes`, so they become links
> in generated HTML.
> 
> We did this for qapi/ in merge commit 504632dcc631.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qga/qapi-schema.json | 50 ++++++++++++++++++++++----------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


> @@ -585,7 +585,7 @@
>  # - pm-utils (via pm-hibernate)
>  # - manual write into sysfs
>  #
> -# IMPORTANT: guest-suspend-ram requires working wakeup support in
> +# IMPORTANT: `guest-suspend-ram` requires working wakeup support in
>  # QEMU. You should check QMP command query-current-machine returns
>  # wakeup-suspend-support: true before issuing this command.  Failure

I presume you're not updating 'query-current-machine' and
'wakeup-suspend-support' due to an inability do cross references
across the two QAPI schemas ?



With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|