From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C664C83F1A for ; Thu, 17 Jul 2025 05:25:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A1832832EB; Thu, 17 Jul 2025 07:25:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=reject dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 69779832DA; Thu, 17 Jul 2025 07:12:22 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 30628832BF for ; Thu, 17 Jul 2025 07:12:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=reject dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS34.andestech.com [10.0.1.134]) by Atcsqr.andestech.com with ESMTPS id 56H5B2as095416 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Thu, 17 Jul 2025 13:11:02 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS34.andestech.com (10.0.1.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 17 Jul 2025 13:11:02 +0800 Date: Thu, 17 Jul 2025 13:10:58 +0800 From: Leo Liang To: Tom Rini CC: E Shattow , Michal Simek , "Martin Herren" , , Andreas Schwab , Anup Patel , Atish Patra , Bin Meng , "Chia-Wei, Wang" , Conor Dooley , Cyril Jean , Green Wan , "Hal Feng" , Heinrich Schuchardt , Ilias Apalodimas , Jerome Forissier , Junhui Liu , Kongyang Liu , Maksim Kiselev , Marek Vasut , Martin Schwan , Mattijs Korpershoek , Minda Chen , "Padmarao Begari" , Palmer Dabbelt , "Paul Walmsley" , Peter Robinson , Rick Chen , Sean Anderson , "Simon Glass" , Sumit Garg , "Thomas Bonnefille" , Wei Fu , Yao Zi , Yixun Lan , Yuri Zaporozhets Subject: Re: [PATCH 0/3] Update riscv's SYS_BOOTM_LEN to the most commonly used value. Message-ID: References: <20250714133345.128853-1-sputnik@on-the-web.ch> <9529db2f-ff07-448e-99b4-65dde605b0ec@amd.com> <20250716170015.GI193579@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250716170015.GI193579@bill-the-cat> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-ClientProxiedBy: ATCPCS33.andestech.com (10.0.1.100) To ATCPCS34.andestech.com (10.0.1.134) X-DKIM-Results: atcpcs34.andestech.com; dkim=none; X-DNSRBL: X-MAIL: Atcsqr.andestech.com 56H5B2as095416 X-Mailman-Approved-At: Thu, 17 Jul 2025 07:25:12 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, Jul 16, 2025 at 11:00:15AM -0600, Tom Rini wrote: > [EXTERNAL MAIL] > Date: Wed, 16 Jul 2025 11:00:15 -0600 > From: Tom Rini > To: E Shattow > Cc: Michal Simek , Martin Herren > , u-boot@lists.denx.de, Andreas Schwab > , Anup Patel , Atish Patra > , Bin Meng , "Chia-Wei, Wang" > , Conor Dooley , > Cyril Jean , Green Wan , > Hal Feng , Heinrich Schuchardt > , Ilias Apalodimas , > Jerome Forissier , Junhui Liu > , Kongyang Liu , Leo > Yu-Chi Liang , Maksim Kiselev > , Marek Vasut , > Martin Schwan , Mattijs Korpershoek > , Minda Chen , > Padmarao Begari , Palmer Dabbelt > , Paul Walmsley , Peter > Robinson , Rick Chen , Sean > Anderson , Simon Glass , Sumit Garg > , Thomas Bonnefille > , Wei Fu , Yao Zi > , Yixun Lan , Yuri Zaporozhets > > Subject: Re: [PATCH 0/3] Update riscv's SYS_BOOTM_LEN to the most commonly > used value. > > On Tue, Jul 15, 2025 at 06:35:17PM -0700, E Shattow wrote: > > > > > > On 7/15/25 04:27, Michal Simek wrote: > > > > > > > > > On 7/14/25 15:33, Martin Herren wrote: > > >> > > >> The most commonly used SYS_BOOTM_LEN for riscv is 0x4000000 which is > > >> used in 25 of the current defconfigs. > > >> > > >> The previous default config value of 0x800000 was only used in 8 > > >> defconfigs. > > >> > > >> This patch sets the default to this value. > > >> > > >> Command used to get the stats of the used values on RISCV defconfigs: > > >> > > >> ``` > > >> grep -l "CONFIG_RISCV=y" configs/* | \ > > >>   xargs -I {} sh -c "grep -H CONFIG_SYS_BOOTM_LEN {} || echo > > >> {}:DEFAULT" | \ > > >>   cut -d ':' -f 2 | sort | uniq -c > > >> ``` > > >> > > >> Changes in v2: > > >> - Resubmit using another mail provider to prevent mangling and signature > > >>    attachement. > > >> > > >> Martin Herren (3): > > >>    riscv: Set SYS_BOOTM_LEN explicitly to 0x800000 > > >>    riscv: Set SYS_BOOTM_LEN default to 0x4000000 > > >>    riscv: Remove default SYS_BOOTM_LEN from defconfig > > >> > > >>   boot/Kconfig                            | 2 +- > > >>   configs/ae350_rv32_defconfig            | 1 - > > >>   configs/ae350_rv32_falcon_defconfig     | 1 - > > >>   configs/ae350_rv32_falcon_xip_defconfig | 1 - > > >>   configs/ae350_rv32_spl_defconfig        | 1 - > > >>   configs/ae350_rv32_spl_xip_defconfig    | 1 - > > >>   configs/ae350_rv32_xip_defconfig        | 1 - > > >>   configs/ae350_rv64_defconfig            | 1 - > > >>   configs/ae350_rv64_falcon_defconfig     | 1 - > > >>   configs/ae350_rv64_falcon_xip_defconfig | 1 - > > >>   configs/ae350_rv64_spl_defconfig        | 1 - > > >>   configs/ae350_rv64_spl_xip_defconfig    | 1 - > > >>   configs/ae350_rv64_xip_defconfig        | 1 - > > >>   configs/ibex-ast2700_defconfig          | 1 - > > >>   configs/k230_canmv_defconfig            | 1 + > > >>   configs/microchip_mpfs_icicle_defconfig | 1 + > > >>   configs/milkv_duo_defconfig             | 1 - > > >>   configs/qemu-riscv32_defconfig          | 1 - > > >>   configs/qemu-riscv32_smode_defconfig    | 1 - > > >>   configs/qemu-riscv32_spl_defconfig      | 1 - > > >>   configs/qemu-riscv64_defconfig          | 1 - > > >>   configs/qemu-riscv64_smode_defconfig    | 1 - > > >>   configs/qemu-riscv64_spl_defconfig      | 1 - > > >>   configs/sifive_unleashed_defconfig      | 1 - > > >>   configs/sifive_unmatched_defconfig      | 1 - > > >>   configs/sipeed_licheerv_nano_defconfig  | 1 - > > >>   configs/sipeed_maix_bitm_defconfig      | 1 + > > >>   configs/sipeed_maix_smode_defconfig     | 1 + > > >>   configs/starfive_visionfive2_defconfig  | 1 - > > >>   configs/th1520_lpi4a_defconfig          | 1 - > > >>   configs/xilinx_mbv32_defconfig          | 1 + > > >>   configs/xilinx_mbv32_smode_defconfig    | 1 + > > >>   configs/xilinx_mbv64_defconfig          | 1 + > > >>   configs/xilinx_mbv64_smode_defconfig    | 1 + > > >>   34 files changed, 9 insertions(+), 26 deletions(-) > > >> > > > > > > I don't mind with these changes. It is just value which can be changed. > > > > > > Acked-by; Michal Simek # xilinx_mbv > > > > > > Thanks > > > Michal > > > > > > > > > > Is there some reason for the value from documentation about the > > architecture? Or is it arbitrary? > > > > I don't really see the sense in a default value which is simply popular > > but not founded in an architectural reasoning. > > > > The values do not change often (ever?) so I miss why there is any > > default at all. > > So, the default for SYS_BOOTM_LEN isn't so much arbitrary as just no > longer reflective of modern times. It's why there's larger defaults for > ARM64 for example. Likely RISCV should just also use that as the default > and platforms with very small amounts of RAM should stick with smaller. > > -- > Tom Hi Martin, These changes seem reasonable, and I'm fine with them. If you send a v2 PR incorporating Conor's comment on the first patch, you may add my Reviewed-by tag. Best regards, Leo