From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/S3: don't lose previously collected CPU data
Date: Thu, 17 Jul 2025 12:42:34 +0200 [thread overview]
Message-ID: <aHjTmtA9f_DLOHLf@macbook.local> (raw)
In-Reply-To: <662a4b19-1ea7-47e4-a89e-204fcef3a6f7@suse.com>
On Thu, Jul 17, 2025 at 12:14:54PM +0200, Jan Beulich wrote:
> smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume,
> hence it is wrong to overwrite APs' data using boot_cpu_data. With
> 7126b7f806d54 ("x86/CPU: re-work populating of cpu_data[]") this now
> results in a crash, as the cpu_to_socket() use in smp_store_cpu_info()
> then obtains a bad socket number, much like was already observed in [1].
>
> [1] https://lists.xen.org/archives/html/xen-devel/2025-06/msg01879.html
>
> Fixes: bb502a8ca5925 ("x86: check feature flags after resume")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
prev parent reply other threads:[~2025-07-17 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 10:14 [PATCH] x86/S3: don't lose previously collected CPU data Jan Beulich
2025-07-17 10:42 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHjTmtA9f_DLOHLf@macbook.local \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.