From: Phillip Potter <phil@philpotter.co.uk>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Phillip Potter <phil@philpotter.co.uk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Christoph Hellwig <hch@infradead.org>,
Chris Rankin <rankincj@gmail.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: cdrom: cdrom_mrw_exit() NULL ptr deref
Date: Sun, 20 Jul 2025 12:55:52 +0100 [thread overview]
Message-ID: <aHzZSKqAJR9Wk7SX@equinox> (raw)
In-Reply-To: <z64pki236n2mertom6jmgznj4t3dkxeosr56fhpmykjdrnzs2l@5xlhh7htcaw4>
On Tue, Jul 15, 2025 at 12:32:22PM +0900, Sergey Senozhatsky wrote:
> On (25/07/14 08:22), Jens Axboe wrote:
> > This just looks totally broken, the cdrom layer trying to issue block
> > layer commands at exit time. Perhaps something like the below (utterly
> > untested) patch would be an improvement. Also gets rid of the silly
> > ->exit() hook which exists just for mrw.
>
> I don't have a CD/DVD drive to test this, but from what I can tell
> the patch looks good to me. Thanks for taking a look!
Hi Sergey,
Just to say, I haven't forgotten this :-) Have run a few tests with the
patch and so far looks all good. Still been unable to replicate the
specific issue though. Assuming my testing uncovers nothing else, I will
revert to Jens with fully crafted patch submission in next day or two.
Regards,
Phil
next prev parent reply other threads:[~2025-07-20 11:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 7:04 cdrom: cdrom_mrw_exit() NULL ptr deref Sergey Senozhatsky
2025-07-11 20:46 ` Phillip Potter
2025-07-14 3:10 ` Sergey Senozhatsky
2025-07-14 3:29 ` Sergey Senozhatsky
2025-07-14 4:31 ` Sergey Senozhatsky
2025-07-14 14:22 ` Jens Axboe
2025-07-14 22:57 ` Phillip Potter
2025-07-15 3:32 ` Sergey Senozhatsky
2025-07-15 21:55 ` Phillip Potter
2025-07-20 11:55 ` Phillip Potter [this message]
2025-07-21 3:23 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHzZSKqAJR9Wk7SX@equinox \
--to=phil@philpotter.co.uk \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rankincj@gmail.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.