All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	donald.hunter@gmail.com, almasrymina@google.com, sdf@fomichev.me
Subject: Re: [PATCH net-next 0/5] tools: ynl-gen: print setters for multi-val attrs
Date: Tue, 22 Jul 2025 16:37:39 -0700	[thread overview]
Message-ID: <aIAgw3pgYGUUda4J@mini-arch> (raw)
In-Reply-To: <20250722161927.3489203-1-kuba@kernel.org>

On 07/22, Jakub Kicinski wrote:
> ncdevmem seems to manually prepare the queue attributes. This is not
> ideal, YNL should be providing helpers for this. Make YNL output
> allocation and setter helpers for multi-val attrs.
> 
> Jakub Kicinski (5):
>   tools: ynl-gen: don't add suffix for pure types
>   tools: ynl-gen: move free printing to the print_type_full() helper
>   tools: ynl-gen: print alloc helper for multi-val attrs
>   tools: ynl-gen: print setters for multi-val attrs
>   selftests: drv-net: devmem: use new mattr ynl helpers

Nice improvement over manually doing _present.xxx = yyy!

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

      parent reply	other threads:[~2025-07-22 23:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 16:19 [PATCH net-next 0/5] tools: ynl-gen: print setters for multi-val attrs Jakub Kicinski
2025-07-22 16:19 ` [PATCH net-next 1/5] tools: ynl-gen: don't add suffix for pure types Jakub Kicinski
2025-07-23  8:52   ` Donald Hunter
2025-07-22 16:19 ` [PATCH net-next 2/5] tools: ynl-gen: move free printing to the print_type_full() helper Jakub Kicinski
2025-07-23  8:58   ` Donald Hunter
2025-07-22 16:19 ` [PATCH net-next 3/5] tools: ynl-gen: print alloc helper for multi-val attrs Jakub Kicinski
2025-07-23  9:07   ` Donald Hunter
2025-07-22 16:19 ` [PATCH net-next 4/5] tools: ynl-gen: print setters " Jakub Kicinski
2025-07-23  9:15   ` Donald Hunter
2025-07-22 16:19 ` [PATCH net-next 5/5] selftests: drv-net: devmem: use new mattr ynl helpers Jakub Kicinski
2025-07-22 21:05   ` Mina Almasry
2025-07-23  9:15   ` Donald Hunter
2025-07-22 23:37 ` Stanislav Fomichev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aIAgw3pgYGUUda4J@mini-arch \
    --to=stfomichev@gmail.com \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.