From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7841C83F17 for ; Wed, 23 Jul 2025 04:48:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8748B80CC3; Wed, 23 Jul 2025 04:48:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id BSrI2JSZ5183; Wed, 23 Jul 2025 04:48:39 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F40D380CC9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1753246119; bh=b+GT+S1VonwXFIy8ZT9VZzn25ILjotrI37Uxrba5dpk=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sxcAVPBJp9cV+NYuGQq8BqNHM5N2b4kVzDC9Ei5L3YfYEMZRqedVQV9rzfPd2IsWR f7b5L+O4+fF2jMzzaSVzY6PLGb4JG6UzbWIcxXUja8xUsUWVU7MAQ68Zo/TP6i60y0 ZQ/9Vg+VvLsRcorpiZZRDISFPwMqLOURv+iio2ybrTMf1uxjeq96blZXiTQJxkAByX mWxxumLRfsbwarZ/BIBqVXCg227utqqSBuOU9+5DJZ3CkZxWbO7xnbmDMEYOMVu0Nj kKmOu125UTpYOj+ZbmepkHo3PeyWnPzcYEMSoqOdLKGKWko2VRTZHLwkNfrZumotr8 wVGmDWMBlNeFA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id F40D380CC9; Wed, 23 Jul 2025 04:48:38 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 110C1DA for ; Wed, 23 Jul 2025 04:48:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EB98E40FAD for ; Wed, 23 Jul 2025 04:48:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id r4xNtaLbH3AE for ; Wed, 23 Jul 2025 04:48:36 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=192.198.163.19; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4DA5C40C93 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4DA5C40C93 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4DA5C40C93 for ; Wed, 23 Jul 2025 04:48:36 +0000 (UTC) X-CSE-ConnectionGUID: EYou51E7TAS3CTsFaabLuQ== X-CSE-MsgGUID: ECaVzh+UQRSoc1mypOnVyA== X-IronPort-AV: E=McAfee;i="6800,10657,11500"; a="54613673" X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="54613673" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2025 21:48:36 -0700 X-CSE-ConnectionGUID: sNJc5pEmTV238Zug66iE+w== X-CSE-MsgGUID: 5xsNh3H2RwSNGd3ttfay0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="164973226" Received: from mev-dev.igk.intel.com ([10.237.112.144]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2025 21:48:34 -0700 Date: Wed, 23 Jul 2025 06:47:25 +0200 From: Michal Swiatkowski To: Simon Horman Cc: Michal Swiatkowski , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com, dawid.osuchowski@linux.intel.com Message-ID: References: <20250722104600.10141-1-michal.swiatkowski@linux.intel.com> <20250722104600.10141-10-michal.swiatkowski@linux.intel.com> <20250722145428.GM2459@horms.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250722145428.GM2459@horms.kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753246116; x=1784782116; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qNjmRPPIJN5Zjpha05dmWoSkyDjdBWOVgWeDdaqiQpY=; b=SwoNWemPJu1AFwMgjOlqUcS15Lo7BQ6/K8XfuFVvP4idhzRYfjejIe9m sxXyQM6CsjijCle54cbqw4nohj7cQoY0nZiWjbdkG0GHXN9WY0J0cCvRp 4G8iLcAqJUYhNy7lQoHRJEl2KL+olSETnaFttBZeDYJwb46yuPWAO0GxN AVY/bzjhk2McX8uhaCMhBTuh8uQ5ksfYkLlDt89TfIs3L3wH4kgAVvJdi uSFKWnh6+bodP3CsYTVnypXqrhVdOL96fAZm34pjQZN25GdC3isARQdWI 0ST1GuX4b1q97pAnI8l/BSUPJsBUWjKwVMQupMYhUhv6TZ825X/gk8AyP w==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=SwoNWemP Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 09/15] ice: drop driver specific structure from fwlog code X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jul 22, 2025 at 03:54:28PM +0100, Simon Horman wrote: > On Tue, Jul 22, 2025 at 12:45:54PM +0200, Michal Swiatkowski wrote: > > In debugfs pass ice_fwlog structure instead of ice_pf. > > > > The debgufs dirs specific for fwlog can be stored in fwlog structure. > > > > Add debugfs entry point to fwlog api. > > > > Reviewed-by: Przemek Kitszel > > Signed-off-by: Michal Swiatkowski > > ... > > > diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c > > ... > > > @@ -580,9 +569,10 @@ static const struct file_operations ice_debugfs_data_fops = { > > > > /** > > * ice_debugfs_fwlog_init - setup the debugfs directory > > - * @pf: the ice that is starting up > > + * @fwlog: pointer to the fwlog structure > > + * @root: debugfs root entry on which fwlog director will be registered > > */ > > -void ice_debugfs_fwlog_init(struct ice_pf *pf) > > +void ice_debugfs_fwlog_init(struct ice_fwlog *fwlog, struct dentry *root) > > { > > struct dentry *fw_modules_dir; > > struct dentry **fw_modules; > > @@ -598,41 +588,39 @@ void ice_debugfs_fwlog_init(struct ice_pf *pf) > > > > pf->ice_debugfs_pf_fwlog = debugfs_create_dir("fwlog", > > pf->ice_debugfs_pf); > > pf no longer exists in this context. > Right, sorry, I missed that. I will build check each commit before sending v2. Thanks > > - if (IS_ERR(pf->ice_debugfs_pf_fwlog)) > > + if (IS_ERR(fwlog->debugfs)) > > goto err_create_module_files; > > > > - fw_modules_dir = debugfs_create_dir("modules", > > - pf->ice_debugfs_pf_fwlog); > > + fw_modules_dir = debugfs_create_dir("modules", fwlog->debugfs); > > if (IS_ERR(fw_modules_dir)) > > goto err_create_module_files; > > ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D3D3151991 for ; Wed, 23 Jul 2025 04:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753246119; cv=none; b=CygvpV0BP2c9s4YBcT67WgIlGBEG59IEsIflK7z7mpUww9ylbxmH7YXNgk0RxDi3BU14+NtFW3fmecxZAiTNjoI/lNhPwEL91WOx6ktMQ+0GAAMhU/irEHNOKuyL3RcHgUOWdLK1/dV2nsyyRqSBKJrU1SegNo+kyF0gWQa4r/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753246119; c=relaxed/simple; bh=qNjmRPPIJN5Zjpha05dmWoSkyDjdBWOVgWeDdaqiQpY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hy3NRRpo8UaLojTGHgRnFjW2MNXtwTOXxIdfOMAVoYZEPZbvggC8omTbGwbqILRA1oy3A5VhRwYPo4tKI+xiQbzVSjQCys6SyKYRu74Wn0qL4ZHYra+CsEz0qXMsTaoF3hRIzuALQwre7Evw382xHbCdH9iPvVgX5rf4xzruLKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FEBi6hqY; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FEBi6hqY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753246118; x=1784782118; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qNjmRPPIJN5Zjpha05dmWoSkyDjdBWOVgWeDdaqiQpY=; b=FEBi6hqYqDU/qSwL4N+31umbaH3++EJOWNhxlkh/GwSr1WHncy7bgkRB RdxjC/+LX/WQzJSSjAp2tQnvhOAkvU60JHXcsblZ06IPaAjuH6sl+qthR aCWJq7TlQSCVxkEqfTP4UKSqhty0CZPV7Gt78sLlOttLhG2IWVMoqZlo7 Ks23Pqmy/MDEfDujTFee1olI+DC9qN3EwsQTNZrwlGbgKjpaNLeGiSOqP SXusNNAsADVhIuTjp8mfiGXKRV91pQAJbfHCH+s2lc9idZR46yxqlxYyu osbc/sWhxL1cBwrLikzB35Nm8h3c+H+2aywzBhaiDviFywS1mLKjDiFS/ g==; X-CSE-ConnectionGUID: Alc+jd6DTPGEXXyhOAOrFg== X-CSE-MsgGUID: oSrNSBepQlersAZnSK1L/g== X-IronPort-AV: E=McAfee;i="6800,10657,11500"; a="54613674" X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="54613674" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2025 21:48:36 -0700 X-CSE-ConnectionGUID: sNJc5pEmTV238Zug66iE+w== X-CSE-MsgGUID: 5xsNh3H2RwSNGd3ttfay0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="164973226" Received: from mev-dev.igk.intel.com ([10.237.112.144]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2025 21:48:34 -0700 Date: Wed, 23 Jul 2025 06:47:25 +0200 From: Michal Swiatkowski To: Simon Horman Cc: Michal Swiatkowski , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com, dawid.osuchowski@linux.intel.com Subject: Re: [PATCH iwl-next v1 09/15] ice: drop driver specific structure from fwlog code Message-ID: References: <20250722104600.10141-1-michal.swiatkowski@linux.intel.com> <20250722104600.10141-10-michal.swiatkowski@linux.intel.com> <20250722145428.GM2459@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250722145428.GM2459@horms.kernel.org> On Tue, Jul 22, 2025 at 03:54:28PM +0100, Simon Horman wrote: > On Tue, Jul 22, 2025 at 12:45:54PM +0200, Michal Swiatkowski wrote: > > In debugfs pass ice_fwlog structure instead of ice_pf. > > > > The debgufs dirs specific for fwlog can be stored in fwlog structure. > > > > Add debugfs entry point to fwlog api. > > > > Reviewed-by: Przemek Kitszel > > Signed-off-by: Michal Swiatkowski > > ... > > > diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c > > ... > > > @@ -580,9 +569,10 @@ static const struct file_operations ice_debugfs_data_fops = { > > > > /** > > * ice_debugfs_fwlog_init - setup the debugfs directory > > - * @pf: the ice that is starting up > > + * @fwlog: pointer to the fwlog structure > > + * @root: debugfs root entry on which fwlog director will be registered > > */ > > -void ice_debugfs_fwlog_init(struct ice_pf *pf) > > +void ice_debugfs_fwlog_init(struct ice_fwlog *fwlog, struct dentry *root) > > { > > struct dentry *fw_modules_dir; > > struct dentry **fw_modules; > > @@ -598,41 +588,39 @@ void ice_debugfs_fwlog_init(struct ice_pf *pf) > > > > pf->ice_debugfs_pf_fwlog = debugfs_create_dir("fwlog", > > pf->ice_debugfs_pf); > > pf no longer exists in this context. > Right, sorry, I missed that. I will build check each commit before sending v2. Thanks > > - if (IS_ERR(pf->ice_debugfs_pf_fwlog)) > > + if (IS_ERR(fwlog->debugfs)) > > goto err_create_module_files; > > > > - fw_modules_dir = debugfs_create_dir("modules", > > - pf->ice_debugfs_pf_fwlog); > > + fw_modules_dir = debugfs_create_dir("modules", fwlog->debugfs); > > if (IS_ERR(fw_modules_dir)) > > goto err_create_module_files; > > ...