Re: [Intel-wired-lan] [PATCH iwl-next v1 02/15] ice: move get_fwlog_data() to fwlog file

[Michal Swiatkowski <michal.swiatkowski@linux.intel.com>]

On Tue, Jul 22, 2025 at 12:02:52PM +0000, Loktionov, Aleksandr wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> > Of Michal Swiatkowski
> > Sent: Tuesday, July 22, 2025 12:46 PM
> > To: intel-wired-lan@lists.osuosl.org
> > Cc: netdev@vger.kernel.org; Kitszel, Przemyslaw
> > <przemyslaw.kitszel@intel.com>; dawid.osuchowski@linux.intel.com;
> > Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> > Subject: [Intel-wired-lan] [PATCH iwl-next v1 02/15] ice: move
> > get_fwlog_data() to fwlog file
> > 
> > Change the function prototype to receive hw structure instead of pf to
> > simplify the call. Instead of passing whole event pass only msg_buf
> > pointer and length.
> > 
> > Make ice_fwlog_ring_full() static as it isn't  called from any other
> > context.
> > 
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> > ---
> >  drivers/net/ethernet/intel/ice/ice_fwlog.c | 27 +++++++++++++++++++-
> > drivers/net/ethernet/intel/ice/ice_fwlog.h |  2 +-
> > drivers/net/ethernet/intel/ice/ice_main.c  | 29 ++--------------------
> >  3 files changed, 29 insertions(+), 29 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> > b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> > index e48856206648..ea5d6d2d3f30 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> > @@ -6,7 +6,7 @@
> >  #include "ice_common.h"
> >  #include "ice_fwlog.h"
> > 
> > -bool ice_fwlog_ring_full(struct ice_fwlog_ring *rings)
> > +static bool ice_fwlog_ring_full(struct ice_fwlog_ring *rings)
> >  {
> >  	u16 head, tail;
> > 
> Can you consider adding kernel-doc for ice_fwlog_ring_full()?
> 

I will add it.