From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D34342192F8 for ; Wed, 23 Jul 2025 04:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753246791; cv=none; b=ElbEkY5Xsof0AHcXW2I/DEB93agEGPqkslF7ga+QpY4XSw7PU9SYKiMFXDTGR+DhKYIsGTlBu0XuwcF4G5DX3lMf1r1CZCRdE4Tek3Xx1A2VLzV10pKwQgND2WDzsaDk8C2MqypmRTEMWloISGhpj0WN+xhn6OQ8pdRq/4tYgwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753246791; c=relaxed/simple; bh=bUWkVDl1xsG0268an9XDncsjM9CP5KQHVRX4OUyWoHo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jz1K15te4fBZTNjApHv+Rj8zREryrFcy+wYfAQ7koBgAK9ElPiPgGaFDwg1MOzlj5vhW5OXlMtItMgrzcVXXHBXFjEFa5T0r8Xi6kFq6TraS+xsLluhDcuWwTiR/cRmWBk7X0OOVuxK6roaH8Mgyb/Hdx+CbACgqYTot18e2hUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ueRZd-0006yY-RI; Wed, 23 Jul 2025 06:59:25 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ueRZa-009piQ-2a; Wed, 23 Jul 2025 06:59:22 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ueRZa-0010Bg-2C; Wed, 23 Jul 2025 06:59:22 +0200 Date: Wed, 23 Jul 2025 06:59:22 +0200 From: Oleksij Rempel To: Tristram.Ha@microchip.com Cc: Oleksij Rempel , Michael Grzeschik , Woojung Huh , Andrew Lunn , Vladimir Oltean , Maxime Chevallier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: microchip: Fix wrong rx drop MIB counter for KSZ8863 Message-ID: References: <20250723030403.56878-1-Tristram.Ha@microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250723030403.56878-1-Tristram.Ha@microchip.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Hi Tristram, On Tue, Jul 22, 2025 at 08:04:03PM -0700, Tristram.Ha@microchip.com wrote: > From: Tristram Ha > > When KSZ8863 support was first added to KSZ driver the RX drop MIB > counter was somehow defined as 0x105. The TX drop MIB counter > starts at 0x100 for port 1, 0x101 for port 2, and 0x102 for port 3, so > the RX drop MIB counter should start at 0x103 for port 1, 0x104 for > port 2, and 0x105 for port 3. > > There are 5 ports for KSZ8895, so its RX drop MIB counter starts at > 0x105. > > Fixes: 4b20a07e103f ("net: dsa: microchip: ksz8795: add support for ksz88xx chips") > Signed-off-by: Tristram Ha Reviewed-by: Oleksij Rempel Thank you for your patch! -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |