From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83D74217F31 for ; Thu, 24 Jul 2025 07:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753342481; cv=none; b=ROLiZnpDHVuXMUZK6BSh3rFWF7GDfm5D/BraO28cdFBkxKX77MjTTIVLQK09HTPXEjoKELsM5gH6JfsZyMpnBd4f5EmXUHicLD503rMK7lF2mfbB6rHMbgEK/zjH/8MXGBfhg//65OBa38CpCUiZU30cYfXpQmJetNJ970DxH14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753342481; c=relaxed/simple; bh=TYgN8U9wXkI2grtnzziutELEQhN3M8VMDw6/GErLUtc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fR51TpepwKzE3PI6pviFNqy1KW5+5Qu/WJAVqdfX3Y8sxiu2EoClyYcWCnCAw/Es3I2vB4j+E1N3jxibgQtvHkYQ6NGGYqwbIjczI3xjIvzOGLtn/kVBi3B2TMhlaw4zCKoSipATLM3OuJKf8/DRJ7/jwBCNI6tomiZWRcj8iHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gn/1d7Yi; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gn/1d7Yi" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ae708b0e83eso145845266b.2 for ; Thu, 24 Jul 2025 00:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753342478; x=1753947278; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TWI57Slc6aJyyVyKYETscKzj1A9LG5NFExHcyZfN1I4=; b=gn/1d7YidnBxGz/Y34PucXcLjHa4Vt6XEtTgiprTpO50KI9Hvbg/6q5oXoRd/UpAkP lAC60NParhqqkOamh4pb1IcsIr4fqoO3DEOFiWOyDwkvD2HoDSZnWe0OnL0BT5k5XzVe 8ldCwFaH4WCnJJxDXbfsmUn9DdnotGlD8LQsgturkV8P9fIHxRmig2cRXdLZt22X9TR9 uziPrZnF0QWagttgGPlYnnuna+EC40FJhINc/qPaL5K7nmGjGPi0N2GVhTRZD/YoFI5+ 1NkD26L653XSi4mmz5neGSXDkP4ijypYYI+ymW7/4SIb+gykaS/RqRO1Mc7a4Igp5n4I tOtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753342478; x=1753947278; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TWI57Slc6aJyyVyKYETscKzj1A9LG5NFExHcyZfN1I4=; b=w4uW5f11eEYczMeKg0GyKuk0TzDyp+JDyguKIXa13BeHigcMeX8M7UitTqtjDKNlLC 3dAB7Pdivw+8Ss5wwCsJvbNRb8qtDvWhEnT13P/W+RLQYVdyLr5czTYecUdQszb9/j6q 982T5WZDJMHhpYSJ/beZoaHQvHYLqpE7V9zmp8+B/tEghaDhO0brJGOkwQLec50EX6AB eE2iPfBWgWlckaEOc0+3pubNU0VYimV2v8GGzSJoE5feqdIehsyBaNfUlaGCM5VgFzfj rvDyzOPZ3LtgHGpJ3jU6sZrlNejWT0xaxhc9DGqZYrMXo09D2qmLUj1wr5BSDgvR1SlW IU+g== X-Forwarded-Encrypted: i=1; AJvYcCWOBey2zZw8TjGuC7tAY5DIBn4vXJm2eckOLxXdebSJh0s4olsetnOyOLSkMbB7rI7wg2yurJSAmEIjdcIK@vger.kernel.org X-Gm-Message-State: AOJu0YzfGgXEpywneMc+y1RoVp6KHty/PV69bLb8F4lzfu24YXU578Pv I4PPCoLcd+A8rLj4+1ejEx+G2/qeqSGKJh0vooefFwiq5lIDuO6kNrplBFJ/yTUp85o= X-Gm-Gg: ASbGncv1da7Q4D9uTxkQGoqhEZkpSGzPTLeyTOMBHSVNezBPHDml/CUq9F5DptAu4My VfdghLYLqVlvV1XmpYfqiOTv5PdC4T+ErnxLUttHjoWtmPwnxhqJUpCc5xMLGM3ChvcvBO3yJQa baPhvEodh2joNwKJRKbQzAr4EdqoBo7gO+04grEZUS0fd2gP3jGAcoZxhZGhbctfAk3xT70pO3F BC1rr7mUl9s9mUERKPiCc4KVQcVb57omheorAP3d03n5KjG3CaRoILYK3LYSk+jamyTpwGHYzOO 5/AQt2mDldmrLabqn276PDf5DGQyiPk/bLapNiq/4/WLOlvrxD7hvCBL8lAjEowiUH87GbXalFy AWTSlU8G+LDCWUPZ9pGr5dR4xkrGgF9ra0g== X-Google-Smtp-Source: AGHT+IGOU5tq53uFmqt87ujSJNnr8Psuegs3IGpCOBKNBhU1Xd+EFhtxeNP1kjGPl47XUHyqRueUIw== X-Received: by 2002:a17:906:d54b:b0:ae3:7b53:31bd with SMTP id a640c23a62f3a-af2f865d730mr626970666b.28.1753342477755; Thu, 24 Jul 2025 00:34:37 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:706f:1fb4:134c:465d]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af47c58b3c4sm72543666b.10.2025.07.24.00.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jul 2025 00:34:37 -0700 (PDT) Date: Thu, 24 Jul 2025 09:34:35 +0200 From: Stephan Gerhold To: srinivas.kandagatla@oss.qualcomm.com Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/23] arm64: dts: qcom: sc7280: use dedicated elite-audio dtsi Message-ID: References: <20250723222737.35561-1-srinivas.kandagatla@oss.qualcomm.com> <20250723222737.35561-13-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250723222737.35561-13-srinivas.kandagatla@oss.qualcomm.com> On Wed, Jul 23, 2025 at 11:27:26PM +0100, srinivas.kandagatla@oss.qualcomm.com wrote: > From: Srinivas Kandagatla > > Make use of elite-audio.dtsi and remove the gpr nodes from SoC dtsi. > This move removes duplication. > > Signed-off-by: Srinivas Kandagatla > --- > .../boot/dts/qcom/qcm6490-fairphone-fp5.dts | 1 + > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 1 + > .../boot/dts/qcom/qcm6490-shift-otter.dts | 1 + > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 1 + > arch/arm64/boot/dts/qcom/sc7280-audio.dtsi | 8 +++ > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 + > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 1 + > arch/arm64/boot/dts/qcom/sc7280.dtsi | 68 +------------------ > arch/arm64/boot/dts/qcom/sm7325.dtsi | 1 + > 9 files changed, 16 insertions(+), 67 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-audio.dtsi > > [...] > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > index 5fbcd48f2e2d..8b4717ba0be5 100644 > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -15,6 +15,7 @@ > #include > #include > #include "sc7280.dtsi" > +#include "sc7280-audio.dtsi" ^ > #include "pm7250b.dtsi" > #include "pm7325.dtsi" > #include "pm8350c.dtsi" > diff --git a/arch/arm64/boot/dts/qcom/sc7280-audio.dtsi b/arch/arm64/boot/dts/qcom/sc7280-audio.dtsi > new file mode 100644 > index 000000000000..4ff49550460a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-audio.dtsi > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > +#include "elite-audio.dtsi" > +&q6asmdai{ > + iommus = <&apps_smmu 0x1801 0x0>; > +}; As far as I understand, RB3Gen2 uses AudioReach [1], so we shouldn't have an Elite-based "sc7280-audio.dtsi" included in all boards. In this case, I think we need separate sc7280-audio-elite.dtsi and sc7280-audio-audioreach.dtsi and include what is relevant for the board. [1]: https://lore.kernel.org/linux-arm-msm/20250720173215.3075576-1-quic_pkumpatl@quicinc.com/T/ Thanks, Stephan