From: David Lamparter <equinox@diac24.net>
To: David Lamparter <equinox@diac24.net>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Lorenzo Colitti <lorenzo@google.com>,
Patrick Rohr <prohr@google.com>
Subject: Re: [PATCH net-next 3/4] net/ipv6: use ipv6_fl_get_saddr in output
Date: Thu, 24 Jul 2025 15:53:29 +0200 [thread overview]
Message-ID: <aII62Z85k7UCX-cY@eidolon.nox.tf> (raw)
In-Reply-To: <20250724131828.32155-4-equinox@diac24.net>
Of course I find a mistake half an hour after sending it out...
On Thu, Jul 24, 2025 at 03:18:24PM +0200, David Lamparter wrote:
> @@ -1111,31 +1111,44 @@ static int ip6_dst_lookup_tail(struct net *net, const struct sock *sk,
> struct neighbour *n;
> struct rt6_info *rt;
> #endif
> - int err;
> + int err = 0;
> int flags = 0;
[...]
> struct rt6_info *rt;
> + bool same_vrf;
> + int err = 0;
I accidentally introduced a second, shadow copy of "err"...
*sigh* should've built with W=2 so I get -Wshadow
...fixing and resending.
-David
next prev parent reply other threads:[~2025-07-24 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 13:18 [PATCH net-next 0/4] net/ipv6: RFC6724 rule 5.5 preparations David Lamparter
2025-07-24 13:18 ` [PATCH net-next 1/4] net/ipv6: flatten ip6_route_get_saddr David Lamparter
2025-07-24 13:18 ` [PATCH net-next 2/4] net/ipv6: create ipv6_fl_get_saddr David Lamparter
2025-07-24 13:18 ` [PATCH net-next 3/4] net/ipv6: use ipv6_fl_get_saddr in output David Lamparter
2025-07-24 13:53 ` David Lamparter [this message]
2025-07-24 13:18 ` [PATCH net-next 4/4] net/ipv6: drop ip6_route_get_saddr David Lamparter
2025-07-24 18:41 ` [syzbot ci] Re: net/ipv6: RFC6724 rule 5.5 preparations syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aII62Z85k7UCX-cY@eidolon.nox.tf \
--to=equinox@diac24.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=prohr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.