All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Chaignon <paul.chaignon@gmail.com>
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>
Subject: Re: [PATCH bpf-next 3/4] selftests/bpf: Test cross-sign 64bits range refinement
Date: Thu, 24 Jul 2025 16:03:34 +0200	[thread overview]
Message-ID: <aII9NupeihYc0xHj@mail.gmail.com> (raw)
In-Reply-To: <755dfeb5b02a1d3b5dd8b87a5aeb822628a93996.camel@gmail.com>

On Mon, Jul 21, 2025 at 02:30:07PM -0700, Eduard Zingerman wrote:
> On Sat, 2025-07-19 at 16:23 +0200, Paul Chaignon wrote:

[...]

> I think two more test cases are needed:
> - when intersection is on the other side of the interval;
> - when signed and unsigned intervals overlap in two places.

Thanks for the review! I've added the two new tests in the v2, along
with appropriate __msg checks. I also made sure the tests fail as
expected without the first patch improving range refinement.


  reply	other threads:[~2025-07-24 14:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-19 14:20 [PATCH bpf-next 0/4] bpf: Improve 64bits bounds refinement Paul Chaignon
2025-07-19 14:22 ` [PATCH bpf-next 1/4] bpf: Improve bounds when s64 crosses sign boundary Paul Chaignon
2025-07-21 21:29   ` Eduard Zingerman
2025-07-22  7:32   ` Shung-Hsi Yu
2025-07-22 22:09     ` Paul Chaignon
2025-07-23  7:49       ` Shung-Hsi Yu
2025-07-19 14:22 ` [PATCH bpf-next 2/4] selftests/bpf: Update reg_bound range refinement logic Paul Chaignon
2025-07-21 21:29   ` Eduard Zingerman
2025-07-22 21:20     ` Paul Chaignon
2025-07-22 21:26       ` Eduard Zingerman
2025-07-19 14:23 ` [PATCH bpf-next 3/4] selftests/bpf: Test cross-sign 64bits range refinement Paul Chaignon
2025-07-21 21:30   ` Eduard Zingerman
2025-07-24 14:03     ` Paul Chaignon [this message]
2025-07-19 14:24 ` [PATCH bpf-next 4/4] selftests/bpf: Test invariants on JSLT crossing sign Paul Chaignon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aII9NupeihYc0xHj@mail.gmail.com \
    --to=paul.chaignon@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.