From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
mm-commits@vger.kernel.org, stable@vger.kernel.org,
senozhatsky@chromium.org, rostedt@goodmis.org, pmladek@suse.com,
linux@rasmusvillemoes.dk, herbert@gondor.apana.org.au
Subject: Re: + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch
Date: Thu, 24 Jul 2025 14:42:18 +0300 [thread overview]
Message-ID: <aIIcGulQp7MOsYtP@smile.fi.intel.com> (raw)
In-Reply-To: <20250724084012.5d7bbc47@canb.auug.org.au>
On Thu, Jul 24, 2025 at 08:40:12AM +1000, Stephen Rothwell wrote:
> On Wed, 23 Jul 2025 18:29:34 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, Jul 21, 2025 at 02:13:52PM -0700, Andrew Morton wrote:
> >
> > > ------------------------------------------------------
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Subject: sprintf.h requires stdarg.h
> > > Date: Mon, 21 Jul 2025 16:15:57 +1000
> > >
> > > In file included from drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c:4:
> > > include/linux/sprintf.h:11:54: error: unknown type name 'va_list'
> > > 11 | __printf(2, 0) int vsprintf(char *buf, const char *, va_list);
> > > | ^~~~~~~
> > > include/linux/sprintf.h:1:1: note: 'va_list' is defined in header '<stdarg.h>'; this is probably fixable by adding '#include <stdarg.h>'
...
> > > #include <linux/compiler_attributes.h>
> > > #include <linux/types.h>
> > > +#include <linux/stdarg.h>
> >
> > Can we prevent the ordering?
>
> I am not sure what you mean by this. Do you want alphabetical, reverse
> christmas tree, or something else? Or are you concerned with something
> completely different?
Alphabetical
#include <linux/compiler_attributes.h>
#include <linux/stdarg.h>
#include <linux/types.h>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-07-24 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 21:13 + sprintfh-requires-stdargh.patch added to mm-hotfixes-unstable branch Andrew Morton
2025-07-23 15:29 ` Andy Shevchenko
2025-07-23 22:39 ` Andrew Morton
2025-07-23 22:40 ` Stephen Rothwell
2025-07-24 11:42 ` Andy Shevchenko [this message]
2025-07-24 13:46 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIIcGulQp7MOsYtP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux@rasmusvillemoes.dk \
--cc=mm-commits@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sfr@canb.auug.org.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.