From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Salah Triki <salah.triki@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7280a: Remove unused macros
Date: Thu, 24 Jul 2025 15:02:38 +0300 [thread overview]
Message-ID: <aIIg3m1eXC3dNfeM@smile.fi.intel.com> (raw)
In-Reply-To: <aIIQ3xxCNfpTouxQ@pc>
On Thu, Jul 24, 2025 at 11:54:23AM +0100, Salah Triki wrote:
> This is to fix the following warnings when compiling the ad7280a driver using
> LLVM=1 and W=2:
W=2 ?! No, please don't do that. W=2 is for informative purposes. Better spend
your efforts against W=1 which are still plenty in the kernel.
On top of that, often the definitions is a (arguable not the best) piece of
documentation of the HW, we don't drop them because they are unused (today).
NAK.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-07-24 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 10:54 [PATCH] iio: adc: ad7280a: Remove unused macros Salah Triki
2025-07-24 11:06 ` Nuno Sá
2025-07-24 11:28 ` Jonathan Cameron
2025-07-24 12:02 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIIg3m1eXC3dNfeM@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.