From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jiqian Chen <Jiqian.Chen@amd.com>
Cc: xen-devel@lists.xenproject.org, Huang Rui <ray.huang@amd.com>
Subject: Re: [PATCH v8 7/8] vpci/msi: Free MSI resources when init_msi() fails
Date: Thu, 24 Jul 2025 16:52:01 +0200 [thread overview]
Message-ID: <aIJIkZ6KKY37utNE@macbook.local> (raw)
In-Reply-To: <20250724055006.29843-8-Jiqian.Chen@amd.com>
On Thu, Jul 24, 2025 at 01:50:05PM +0800, Jiqian Chen wrote:
> When init_msi() fails, current logic return fail and free MSI-related
> resources in vpci_deassign_device(). But the previous new changes will
> hide MSI capability and return success, it can't reach
> vpci_deassign_device() to remove resources if hiding success, so those
> resources must be removed in cleanup function of MSI.
>
> To do that, implement cleanup function for MSI.
>
> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
next prev parent reply other threads:[~2025-07-24 14:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 5:49 [PATCH v8 0/8] Support hiding capability when its initialization fails Jiqian Chen
2025-07-24 5:49 ` [PATCH v8 1/8] vpci/header: Emulate extended capability list for dom0 Jiqian Chen
2025-07-24 8:09 ` Jan Beulich
2025-07-24 14:16 ` Roger Pau Monné
2025-07-24 5:50 ` [PATCH v8 2/8] vpci: Refactor REGISTER_VPCI_INIT Jiqian Chen
2025-07-24 14:28 ` Roger Pau Monné
2025-07-25 3:15 ` Chen, Jiqian
2025-07-25 8:08 ` Roger Pau Monné
2025-07-25 8:22 ` Chen, Jiqian
2025-07-24 5:50 ` [PATCH v8 3/8] vpci: Hide legacy capability when it fails to initialize Jiqian Chen
2025-07-24 14:47 ` Roger Pau Monné
2025-07-24 5:50 ` [PATCH v8 4/8] vpci: Hide extended " Jiqian Chen
2025-07-24 5:50 ` [PATCH v8 5/8] vpci: Refactor vpci_remove_register to remove matched registers Jiqian Chen
2025-07-24 5:50 ` [PATCH v8 6/8] vpci/rebar: Free Rebar resources when init_rebar() fails Jiqian Chen
2025-07-24 5:50 ` [PATCH v8 7/8] vpci/msi: Free MSI resources when init_msi() fails Jiqian Chen
2025-07-24 14:52 ` Roger Pau Monné [this message]
2025-07-24 5:50 ` [PATCH v8 8/8] vpci/msix: Free MSIX resources when init_msix() fails Jiqian Chen
2025-07-24 15:59 ` Roger Pau Monné
2025-07-25 2:50 ` Chen, Jiqian
2025-07-25 8:06 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIJIkZ6KKY37utNE@macbook.local \
--to=roger.pau@citrix.com \
--cc=Jiqian.Chen@amd.com \
--cc=ray.huang@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.