From: Tao Ren <rentao.bupt@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Tao Ren <taoren@meta.com>
Subject: Re: [PATCH v3 10/13] ARM: dts: aspeed: Add Facebook Fuji-data64 (AST2600) Board
Date: Thu, 24 Jul 2025 22:18:53 -0700 [thread overview]
Message-ID: <aIMTvUyHGd/ikKY9@localhost.localdomain> (raw)
In-Reply-To: <769d6817-ee97-4a23-b013-29bc875a00cb@lunn.ch>
On Thu, Jul 24, 2025 at 02:53:39PM +0200, Andrew Lunn wrote:
> On Wed, Jul 23, 2025 at 06:03:49PM -0700, Tao Ren wrote:
> > On Thu, Jul 24, 2025 at 02:03:20AM +0200, Andrew Lunn wrote:
> > > > +&mac3 {
> > > > + status = "okay";
> > > > + phy-mode = "rgmii";
> > >
> > > Does the PCB have extra long clock lines to implement the 2ns delay?
> > >
> > > Andrew
> >
> > Hi Andrew,
> >
> > Thank you for catching it. I didn't notice the settings because the file
> > is copied from the exiting fuji.dts with minor changes.
> >
> > The delay is currently introduced on MAC side (by manually setting SCU
> > registers), but I guess I can update phy-mode to "rgmii-id" so the delay
> > can be handled by the PHY?
>
> That would be good, if it works. The problem with the current code is
> that those SCU registers are not set as part of the MAC driver, so it
> is hard to know what value they have.
>
> Andrew
Hi Andrew,
I set phy-mode to rgmii-id (letting BCM54616S handle RX/TX delay) and
cleared SCU350 (MAC3/4 RGMII delay) register, but somehow BMC is not
reachable over ethernet.
Let me see if I missed other settings. I will drop the mac entry from v4
if I cannot make it work by next Monday.
Thanks,
Tao
next prev parent reply other threads:[~2025-07-25 5:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 23:29 [PATCH v3 00/13] ARM: dts: aspeed: Add Meta Darwin dts rentao.bupt
2025-07-23 23:29 ` [PATCH v3 01/13] ARM: dts: aspeed: wedge400: Fix DTB warnings rentao.bupt
2025-07-23 23:29 ` [PATCH v3 02/13] ARM: dts: aspeed: fuji: " rentao.bupt
2025-07-23 23:29 ` [PATCH v3 03/13] ARM: dts: aspeed: Fix DTB warnings in ast2600-facebook-netbmc-common.dtsi rentao.bupt
2025-07-23 23:30 ` [PATCH v3 04/13] ARM: dts: aspeed: Move eMMC out of ast2600-facebook-netbmc-common.dtsi rentao.bupt
2025-07-23 23:30 ` [PATCH v3 05/13] ARM: dts: aspeed: Add facebook-bmc-flash-layout-128-data64.dtsi rentao.bupt
2025-07-23 23:30 ` [PATCH v3 06/13] dt-bindings: arm: aspeed: add Facebook Wedge400-data64 board rentao.bupt
2025-07-24 10:03 ` Krzysztof Kozlowski
2025-07-23 23:30 ` [PATCH v3 07/13] ARM: dts: aspeed: Add Facebook Wedge400-data64 (AST2500) BMC rentao.bupt
2025-07-24 8:05 ` Krzysztof Kozlowski
2025-07-25 5:20 ` Tao Ren
2025-07-23 23:30 ` [PATCH v3 08/13] ARM: dts: aspeed: wedge400: Include wedge400-data64.dts rentao.bupt
2025-07-23 23:30 ` [PATCH v3 09/13] dt-bindings: arm: aspeed: add Facebook Fuji-data64 board rentao.bupt
2025-07-23 23:30 ` [PATCH v3 10/13] ARM: dts: aspeed: Add Facebook Fuji-data64 (AST2600) Board rentao.bupt
2025-07-24 0:03 ` Andrew Lunn
2025-07-24 1:03 ` Tao Ren
2025-07-24 12:53 ` Andrew Lunn
2025-07-25 5:18 ` Tao Ren [this message]
2025-07-27 5:57 ` Tao Ren
2025-07-27 15:45 ` Andrew Lunn
2025-07-28 5:34 ` Tao Ren
2025-07-23 23:30 ` [PATCH v3 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts rentao.bupt
2025-07-23 23:30 ` [PATCH v3 12/13] dt-bindings: arm: aspeed: add Facebook Darwin board rentao.bupt
2025-07-23 23:30 ` [PATCH v3 13/13] ARM: dts: aspeed: Add Facebook Darwin (AST2600) BMC rentao.bupt
2025-07-23 23:44 ` [PATCH v3 00/13] ARM: dts: aspeed: Add Meta Darwin dts Tao Ren
2025-07-25 3:19 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIMTvUyHGd/ikKY9@localhost.localdomain \
--to=rentao.bupt@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=taoren@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.