From: Cyril Hrubis <chrubis@suse.cz>
To: Mike Tipton <mike.tipton@oss.qualcomm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] device-drivers/cpufreq_boost: Don't hardcode to CPU0
Date: Fri, 25 Jul 2025 14:31:02 +0200 [thread overview]
Message-ID: <aIN5Btk4Sn2azE14@yuki.lan> (raw)
In-Reply-To: <20250710170255.4190556-1-mike.tipton@oss.qualcomm.com>
Hi!
> -const char governor[] = SYSFS_CPU_DIR "cpu0/cpufreq/scaling_governor";
> +static int cpu;
> +
> +static const char _governor[] = SYSFS_CPU_DIR "cpu%d/cpufreq/scaling_governor";
Identifiers starting with underscore are reserved for kernel/libc
implementation we shouldn't use them here. I guess that this would be
better as governor_fmt.
> +static char governor[64];
> static char governor_name[16];
>
> -const char maxspeed[] = SYSFS_CPU_DIR "cpu0/cpufreq/scaling_max_freq";
> +static const char _maxspeed[] = SYSFS_CPU_DIR "cpu%d/cpufreq/scaling_max_freq";
Here as well.
Other than that it looks fine. I can push the patch with the change from
_governor to governor_fmt and _maxspeed to maxspeed_fmt if you agree.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-07-25 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 17:02 [LTP] [PATCH v4] device-drivers/cpufreq_boost: Don't hardcode to CPU0 Mike Tipton via ltp
2025-07-24 1:52 ` Mike Tipton via ltp
2025-07-25 12:31 ` Cyril Hrubis [this message]
2025-07-25 14:12 ` Mike Tipton via ltp
2025-07-25 14:33 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIN5Btk4Sn2azE14@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mike.tipton@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.