From: Mahe Tardy <mahe.tardy@gmail.com>
To: Yonghong Song <yhs@meta.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: bpf: LLVM BTF inner map struct type def missing
Date: Fri, 25 Jul 2025 13:51:07 +0200 [thread overview]
Message-ID: <aINvq2iqUJkNBvZT@gmail.com> (raw)
In-Reply-To: <PH0PR15MB5639C7853B00C613ACF18A74CA5CA@PH0PR15MB5639.namprd15.prod.outlook.com>
On Tue, Jul 22, 2025 at 11:02:58PM +0000, Yonghong Song wrote:
> > If you think it's reasonable to fix, I would be interested looking into
> > this.
>
> Looks like this may be something we want to fix as people starts or already uses
> nested maps. So yes, please go ahead to look into this.
Here is my proposal patch https://github.com/llvm/llvm-project/pull/150608.
The idea is to visit inner maps as we visit the global maps during BTF
generation. Unfortunately, for that, I had to add a boolean arg to some
functions, I hope it's okay.
>
> FYI, the llvm patch https://github.com/llvm/llvm-project/pull/141719/ tried to solve
> nested struct definition issue (similar to here). In that case, a type_tag is the
> indicator which allows further type generation. The patch listed llvm source
> locations you likely need to touch.
Thank you, it was very useful to have this pointer!
>
> >
> > [^1]: https://github.com/cilium/ebpf/discussions/1658#discussioncomment-12491339
next prev parent reply other threads:[~2025-07-25 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 18:44 bpf: LLVM BTF inner map struct type def missing Mahe Tardy
2025-07-22 23:02 ` Yonghong Song
2025-07-25 11:51 ` Mahe Tardy [this message]
2025-07-25 17:40 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aINvq2iqUJkNBvZT@gmail.com \
--to=mahe.tardy@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.