Re: [PATCH v2 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory

[Imre Deak <imre.deak@intel.com>]

On Fri, Jul 25, 2025 at 02:36:31PM +0100, Mark Brown wrote:
> On Tue, Jul 22, 2025 at 02:41:53PM +0100, Mark Brown wrote:
> > On Tue, Jul 01, 2025 at 12:07:22PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > Now that everyone passes along the format info to
> > > drm_helper_mode_fill_fb_struct() we can make this behaviour
> > > mandatory and drop the extra lookup.
> > 
> > This patch, which is in -next as 41ab92d35ccd2d66, appears to be
> > triggering warnings on TI x15 boards:
> 
> This regression is still present in today's -next, I've not seen any
> response to my report?

Looks like the following would fix it, could you give it a go?:

diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c
index 30c81e2e5d6b..42da78bcb5a6 100644
--- a/drivers/gpu/drm/omapdrm/omap_fb.c
+++ b/drivers/gpu/drm/omapdrm/omap_fb.c
@@ -440,7 +440,7 @@ struct drm_framebuffer *omap_framebuffer_init(struct drm_device *dev,
                plane->dma_addr  = 0;
        }

-       drm_helper_mode_fill_fb_struct(dev, fb, NULL, mode_cmd);
+       drm_helper_mode_fill_fb_struct(dev, fb, format, mode_cmd);

        ret = drm_framebuffer_init(dev, fb, &omap_framebuffer_funcs);
        if (ret) {