All of lore.kernel.org
 help / color / mirror / Atom feed
From: dmkhn@proton.me
To: Mykola Kvach <xakep.amatop@gmail.com>
Cc: xen-devel@lists.xenproject.org,
	Mykola Kvach <mykola_kvach@epam.com>,
	Anthony PERARD <anthony.perard@vates.tech>
Subject: Re: [PATCH v2] systemd: Add hooks to stop/start xen-watchdog on suspend/resume
Date: Sat, 26 Jul 2025 21:02:17 +0000	[thread overview]
Message-ID: <aIVCVTwUsTD4Y6BV@kraken> (raw)
In-Reply-To: <b44966513abc729f44795c0d5012e1c5fd106477.1752783296.git.mykola_kvach@epam.com>

On Thu, Jul 17, 2025 at 11:16:58PM +0300, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@epam.com>
> 
>  $(XEN_SYSTEMD_MODULES):
>  	rm -f $@.tmp
> diff --git a/tools/hotplug/Linux/systemd/xen-watchdog-sleep.sh b/tools/hotplug/Linux/systemd/xen-watchdog-sleep.sh
> new file mode 100644
> index 0000000000..e9bdadc8fa
> --- /dev/null
> +++ b/tools/hotplug/Linux/systemd/xen-watchdog-sleep.sh
> @@ -0,0 +1,34 @@
> +#!/bin/sh

Is there chance to add `set -e` to harden the error path?

With that correction, please consider:

Reviewed-by: Denis Mukhin <dmukhin@ford.com> 



  parent reply	other threads:[~2025-07-26 21:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17 20:16 [PATCH v2] systemd: Add hooks to stop/start xen-watchdog on suspend/resume Mykola Kvach
2025-07-25 14:04 ` Anthony PERARD
2025-07-26  5:39   ` Mykola Kvach
2025-07-26 21:02 ` dmkhn [this message]
2025-08-05 16:30 ` Andrew Cooper
2025-12-04 23:48 ` [REGRESSION] " Andrew Cooper
2025-12-05 12:41   ` Mykola Kvach
2025-12-05 13:18   ` Mykola Kvach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aIVCVTwUsTD4Y6BV@kraken \
    --to=dmkhn@proton.me \
    --cc=anthony.perard@vates.tech \
    --cc=mykola_kvach@epam.com \
    --cc=xakep.amatop@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.