All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-i3c@lists.infradead.org
Subject: Re: [bug report] i3c: master: Add basic driver for the Renesas I3C controller
Date: Sun, 3 Aug 2025 23:04:07 +0200	[thread overview]
Message-ID: <aI_Ox9ORhE7kACaF@shikoro> (raw)
In-Reply-To: <aIyzJ7HOENL1qp1l@stanley.mountain>

Hi Dan,

thanks for the report. I'd argue it is not a bug, though.

>     677         for (pos = 0; pos < i3c->maxdevs; pos++) {
>     678                 if (newdevs & BIT(pos))
>     679                         i3c_master_add_i3c_dev_locked(m, i3c->addrs[pos]);
> 
> Should we add checking for i3c_master_add_i3c_dev_locked()?

No, I think we should continue to add the remaining devices even if one
fails. Other driver do it also like above.

>     680         }
>     681 
> --> 682         return ret < 0 ? ret : 0;
> 
> Otherwise this could just be "return 0;"

True that, I will send a patch.

Happy hacking,

   Wolfram


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

      reply	other threads:[~2025-08-03 21:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 12:29 [bug report] i3c: master: Add basic driver for the Renesas I3C controller Dan Carpenter
2025-08-03 21:04 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aI_Ox9ORhE7kACaF@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-i3c@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.