From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 8/9] watchdog: rzv2h: Add support for RZ/T2H
Date: Sun, 3 Aug 2025 23:38:01 +0200 [thread overview]
Message-ID: <aI_Wua2TPftUAkwZ@shikoro> (raw)
In-Reply-To: <20250729155915.67758-9-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Tue, Jul 29, 2025 at 04:59:14PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add support for the RZ/T2H watchdog timer. The RZ/T2H requires control of
> the watchdog counter using the WDT Debug Control Register (WDTDCR), which
> allows explicitly stopping and starting the counter. This behavior differs
> from RZ/V2H, which doesn't use WDTDCR, so the driver is extended to handle
> this requirement.
>
> To support this, a new `wdtdcr` flag is introduced in the `rzv2h_of_data`
> structure. When set, the driver maps the WDTDCR register and uses it to
> control the watchdog counter in the start, stop, and restart callbacks.
> Additionally, the clock divisor and count source for RZ/T2H are defined
> to match its hardware configuration.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Well, this new DCR register is really strange, especially its location
in a seperate resource. But given that, your code handling it looks
okay to me, so:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
next prev parent reply other threads:[~2025-08-03 21:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 15:59 [PATCH v2 0/9] Add watchdog driver support for RZ/T2H and RZ/N2H SoCs Prabhakar
2025-07-29 15:59 ` [PATCH v2 1/9] dt-bindings: watchdog: renesas,wdt: Add support for RZ/T2H and RZ/N2H Prabhakar
2025-07-29 15:59 ` [PATCH v2 2/9] watchdog: rzv2h_wdt: Obtain clock-divider ranges from OF match data Prabhakar
2025-08-01 4:03 ` Wolfram Sang
2025-07-29 15:59 ` [PATCH v2 3/9] watchdog: rzv2h_wdt: Obtain CKS divider via OF data Prabhakar
2025-08-01 4:04 ` Wolfram Sang
2025-08-01 11:41 ` Lad, Prabhakar
2025-07-29 15:59 ` [PATCH v2 4/9] watchdog: rzv2h_wdt: Make "oscclk" an optional clock Prabhakar
2025-08-01 4:04 ` Wolfram Sang
2025-07-29 15:59 ` [PATCH v2 5/9] watchdog: rzv2h_wdt: Add support for configurable count clock source Prabhakar
2025-08-01 4:04 ` Wolfram Sang
2025-07-29 15:59 ` [PATCH v2 6/9] watchdog: rzv2h_wdt: Make reset controller optional Prabhakar
2025-08-01 4:04 ` Wolfram Sang
2025-08-01 11:42 ` Lad, Prabhakar
2025-07-29 15:59 ` [PATCH v2 7/9] watchdog: rzv2h: Set min_timeout based on max_hw_heartbeat_ms Prabhakar
2025-08-01 4:10 ` Wolfram Sang
2025-08-01 11:05 ` Lad, Prabhakar
2025-08-01 13:52 ` Guenter Roeck
2025-08-01 15:30 ` Lad, Prabhakar
2025-08-01 18:04 ` Guenter Roeck
2025-08-01 20:51 ` Lad, Prabhakar
2025-08-01 21:04 ` Guenter Roeck
2025-08-02 19:26 ` Lad, Prabhakar
2025-08-03 0:16 ` Guenter Roeck
2025-08-04 11:24 ` Lad, Prabhakar
2025-07-29 15:59 ` [PATCH v2 8/9] watchdog: rzv2h: Add support for RZ/T2H Prabhakar
2025-08-01 4:12 ` Wolfram Sang
2025-08-01 11:15 ` Lad, Prabhakar
2025-08-03 21:38 ` Wolfram Sang [this message]
2025-07-29 15:59 ` [PATCH v2 9/9] watchdog: rzv2h_wdt: Improve error strings and add newlines Prabhakar
2025-08-01 4:17 ` Wolfram Sang
2025-07-29 17:08 ` [PATCH v2 0/9] Add watchdog driver support for RZ/T2H and RZ/N2H SoCs Wolfram Sang
2025-07-29 17:10 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aI_Wua2TPftUAkwZ@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.