From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
aleksander.lobakin@intel.com, przemyslaw.kitszel@intel.com,
piotr.kwapulinski@intel.com, aleksandr.loktionov@intel.com,
jedrzej.jagielski@intel.com, larysa.zaremba@intel.com
Subject: Re: [PATCH net-next 5/8] libie: add adminq helper for converting err to str
Date: Mon, 28 Jul 2025 09:08:31 +0200 [thread overview]
Message-ID: <aIch76xAiGUWd2/b@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250725160930.23f9c420@kernel.org>
On Fri, Jul 25, 2025 at 04:09:30PM -0700, Jakub Kicinski wrote:
> On Thu, 24 Jul 2025 11:28:21 -0700 Tony Nguyen wrote:
> > +const char *libie_aq_str(enum libie_aq_err err)
> > +{
> > + if (err >= ARRAY_SIZE(libie_aq_str_arr) ||
> > + !libie_aq_str_arr[err])
> > + err = __LIBIE_AQ_STR_NUM;
> > +
> > + return libie_aq_str_arr[err];
>
> All the LIBIE error values map to the POSIX ones, right? And this is
> mostly used in error messages. So why not use %pe I wonder..
Hi,
unfortunately no, not all values are mapped correctly (I don't know why,
just FW thing probably :( ).
next prev parent reply other threads:[~2025-07-28 7:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 18:28 [PATCH net-next 0/8][pull request] libie: commonize adminq structure Tony Nguyen
2025-07-24 18:28 ` [PATCH net-next 1/8] ice, libie: move generic adminq descriptors to lib Tony Nguyen
2025-07-24 18:28 ` [PATCH net-next 2/8] ixgbe: use libie adminq descriptors Tony Nguyen
2025-07-24 18:28 ` [PATCH net-next 3/8] i40e: " Tony Nguyen
2025-07-24 18:28 ` [PATCH net-next 4/8] iavf: " Tony Nguyen
2025-07-24 18:28 ` [PATCH net-next 5/8] libie: add adminq helper for converting err to str Tony Nguyen
2025-07-25 23:09 ` Jakub Kicinski
2025-07-28 7:08 ` Michal Swiatkowski [this message]
2025-07-24 18:28 ` [PATCH net-next 6/8] ice: use libie_aq_str Tony Nguyen
2025-07-24 18:28 ` [PATCH net-next 7/8] iavf: " Tony Nguyen
2025-07-24 18:28 ` [PATCH net-next 8/8] i40e: " Tony Nguyen
2025-07-25 23:26 ` [PATCH net-next 0/8][pull request] libie: commonize adminq structure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIch76xAiGUWd2/b@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jedrzej.jagielski@intel.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotr.kwapulinski@intel.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.