Re: [LTP] [PATCH 1/1] fsconfig03: Quit on first error

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Test runs in loop 5000x, if it fails, it pollutes output a lot.
> 
> Currently bcachefs fails 4883x:
> fsconfig03.c:53: TFAIL: fsconfig() passed unexpectedly
> 
> Skip with goto to keep check for a taint flags.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi all,
> 
> or do we want to quit after more errors, e.g. 10x?
> 
> Kind regards,
> Petr
> 
>  testcases/kernel/syscalls/fsconfig/fsconfig03.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/fsconfig/fsconfig03.c b/testcases/kernel/syscalls/fsconfig/fsconfig03.c
> index add54769e0..985278986a 100644
> --- a/testcases/kernel/syscalls/fsconfig/fsconfig03.c
> +++ b/testcases/kernel/syscalls/fsconfig/fsconfig03.c
> @@ -51,15 +51,18 @@ static void run(void)
>  
>  		if (!TST_RET) {
>  			tst_res(TFAIL, "fsconfig() passed unexpectedly");
> +			goto cleanup;

Shouldn't break; be better in this case?

Otherwise it looks good.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp