Re: [PATCH] hw/i386: Fix 'use-legacy-x86-rom' property compatibility

[Zhao Liu <zhao1.liu@intel.com>]

On Wed, Jul 23, 2025 at 08:27:14AM +0200, Cédric Le Goater wrote:
> Date: Wed, 23 Jul 2025 08:27:14 +0200
> From: Cédric Le Goater <clg@redhat.com>
> Subject: [PATCH] hw/i386: Fix 'use-legacy-x86-rom' property compatibility
> 
> Commit 350785d41d8b ("ramfb: Add property to control if load the
> romfile") introduced the `use-legacy-x86-rom` property for the
> `vfio-pci-nohotplug` device, allowing control over VGA BIOS ROM
> loading. However, the property compatibility setting was incorrectly
> applied to the `vfio-pci` device instead, which causes all `vfio-pci`
> devices to fail to load. This change fixes the issue by ensuring the
> property is set on the correct device.
> 
> Fixes: d5fcf0d960d8 ("hw/i386: Add the ramfb romfile compatibility")
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Shaoqin Huang <shahuang@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>  hw/vfio/types.h   | 2 ++
>  hw/core/machine.c | 2 +-
>  hw/i386/microvm.c | 2 +-
>  hw/i386/pc_piix.c | 2 +-
>  hw/i386/pc_q35.c  | 2 +-
>  hw/vfio/pci.c     | 2 --
>  6 files changed, 6 insertions(+), 6 deletions(-)

LGTM. Thanks!

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>