Re: [PATCH v4 3/9] perf annotate: Pass annotation_print_data to annotation_line__write()

[Namhyung Kim <namhyung@kernel.org>]

On Fri, Jul 25, 2025 at 05:23:00PM -0700, Ian Rogers wrote:
> On Fri, Jul 25, 2025 at 12:38 PM Namhyung Kim <namhyung@kernel.org> wrote:
[SNIP]
> > diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
> > index 0f640e4871744262..8fad464a870a2b8e 100644
> > --- a/tools/perf/util/annotate.h
> > +++ b/tools/perf/util/annotate.h
> > @@ -199,8 +199,18 @@ struct annotation_write_ops {
> >         void (*write_graph)(void *obj, int graph);
> >  };
> >
> > +struct annotation_print_data {
> > +       struct hist_entry *he;
> > +       struct evsel *evsel;
> > +       struct arch *arch;
> > +       struct debuginfo *dbg;
> > +       u64 start;
> > +       int addr_fmt_width;
> > +};
> 
> nit: As the scope of this is now global, is it worth commenting it?
> For example, where is start relative to?

Sure, I'll add comments.

> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Namhyung