From: Johan Hovold <johan@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: drop unused module alias
Date: Tue, 29 Jul 2025 11:23:20 +0200 [thread overview]
Message-ID: <aIiTCDy-_EjUt1zd@hovoldconsulting.com> (raw)
In-Reply-To: <CAMuHMdU0E_d3XMj6sDeJy8P_UL7ua-_6CnTYqvf2-TD-WXiR3Q@mail.gmail.com>
Hi Geert,
On Mon, Jul 28, 2025 at 10:56:18AM +0200, Geert Uytterhoeven wrote:
> On Thu, 24 Jul 2025 at 11:21, Johan Hovold <johan@kernel.org> wrote:
> > Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car
> > H3 ES1.* handling") the driver only supports OF probe so drop the unused
> > platform module alias.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> While I don't debate the actual change, I would like to comment on
> the patch description. The driver only ever supported OF probe.
> The call to soc_device_match() was just used to override the match
> data for quirk handling.
The driver initially indeed only supported OF probe, but that changed
with commit ca02a5af650c ("usb: gadget: udc: renesas_usb3: Use
of_device_get_match_data() helper") after which the driver could at
least theoretically also bind based on the platform device name.
Johan
next prev parent reply other threads:[~2025-07-29 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 9:20 [PATCH] usb: gadget: udc: renesas_usb3: drop unused module alias Johan Hovold
2025-07-28 8:56 ` Geert Uytterhoeven
2025-07-29 9:23 ` Johan Hovold [this message]
2025-07-29 9:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIiTCDy-_EjUt1zd@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.