From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jiqian Chen <Jiqian.Chen@amd.com>
Cc: xen-devel@lists.xenproject.org, Huang Rui <ray.huang@amd.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Anthony PERARD <anthony.perard@vates.tech>,
Michal Orzel <michal.orzel@amd.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v9 2/8] vpci: Refactor REGISTER_VPCI_INIT
Date: Tue, 29 Jul 2025 14:47:35 +0200 [thread overview]
Message-ID: <aIjC5ybQLz2HJATc@macbook.local> (raw)
In-Reply-To: <20250728050401.329510-3-Jiqian.Chen@amd.com>
On Mon, Jul 28, 2025 at 01:03:55PM +0800, Jiqian Chen wrote:
> Refactor REGISTER_VPCI_INIT to contain more capability specific
> information, this will benefit further follow-on changes to hide
> capability when initialization fails.
>
> What's more, change the definition of init_header() since it is
> not a capability and it is needed for all devices' PCI config space.
>
> After refactor, the "priority" of initializing capabilities isn't
> needed anymore, so delete its related codes.
>
> Note:
> Call vpci_make_msix_hole() in the end of init_msix() since the change
> of sequence of init_header() and init_msix().
>
> The cleanup hook is also added in this change, even if it's still
> unused. Further changes will make use of it.
>
> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
next prev parent reply other threads:[~2025-07-29 12:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 5:03 [PATCH v9 0/8] Support hiding capability when its initialization fails Jiqian Chen
2025-07-28 5:03 ` [PATCH v9 1/8] vpci/header: Emulate extended capability list for dom0 Jiqian Chen
2025-07-28 5:03 ` [PATCH v9 2/8] vpci: Refactor REGISTER_VPCI_INIT Jiqian Chen
2025-07-29 12:47 ` Roger Pau Monné [this message]
2025-07-28 5:03 ` [PATCH v9 3/8] vpci: Hide legacy capability when it fails to initialize Jiqian Chen
2025-07-28 5:03 ` [PATCH v9 4/8] vpci: Hide extended " Jiqian Chen
2025-07-30 9:50 ` Jan Beulich
2025-07-30 10:19 ` Andrew Cooper
2025-07-30 10:24 ` Jan Beulich
2025-07-30 10:42 ` Nicola Vetrini
2025-07-30 10:46 ` Nicola Vetrini
2025-07-31 6:30 ` Chen, Jiqian
2025-07-28 5:03 ` [PATCH v9 5/8] vpci: Refactor vpci_remove_register to remove matched registers Jiqian Chen
2025-07-30 11:23 ` Andrew Cooper
2025-07-31 6:28 ` Chen, Jiqian
2025-08-04 15:31 ` Roger Pau Monné
2025-07-28 5:03 ` [PATCH v9 6/8] vpci/rebar: Free Rebar resources when init_rebar() fails Jiqian Chen
2025-07-28 5:04 ` [PATCH v9 7/8] vpci/msi: Free MSI resources when init_msi() fails Jiqian Chen
2025-07-28 5:04 ` [PATCH v9 8/8] vpci/msix: Free MSIX resources when init_msix() fails Jiqian Chen
2025-07-29 16:36 ` Roger Pau Monné
2025-07-30 2:52 ` Chen, Jiqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIjC5ybQLz2HJATc@macbook.local \
--to=roger.pau@citrix.com \
--cc=Jiqian.Chen@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=ray.huang@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.