From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AB8FC87FCB for ; Wed, 30 Jul 2025 11:08:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE15910E1A6; Wed, 30 Jul 2025 11:08:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JgskH+4u"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8271C10E1A6 for ; Wed, 30 Jul 2025 11:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753873683; x=1785409683; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yO0BRve+zCl7T1EmGdWRO7edFsB8CxYNoqY/4+4rKnU=; b=JgskH+4u4DHQ3Ukormn6Bv1tqxxq+1KcZZ14FYOntxVxb6/S36VLoHim X7/bx6lyktRFwp84M9D9MuwM2v8B3uj0ra6e4FBCW1z6bsGAspKxxtXFc cTcHLfDfXGC2MuTAx3rKzmFze9Fj8iIgChdQaOQH1Z/k9aYKqXgQJeAnR cAxd2S5CWPUgD3J+imUmyLVysfABo5HwxuCOwJzgrVbc2muuZiIjDdKnS 25pHUMHCXhZomgcNUTaImw8Yq1gGkC9X16i/oMn2f2XGmcR1CGtENNtU1 hSyy2qGbP9v+eiTzmeOjOC6oAN5oceQaDmrZK4aDBZ1pZHd8DtFABn8mw w==; X-CSE-ConnectionGUID: l9I+W0H2RgaTKtMXdrgVkw== X-CSE-MsgGUID: aU6RGX5aRk6v+026uEkLPA== X-IronPort-AV: E=McAfee;i="6800,10657,11506"; a="59996913" X-IronPort-AV: E=Sophos;i="6.16,350,1744095600"; d="scan'208";a="59996913" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2025 04:08:02 -0700 X-CSE-ConnectionGUID: wid76SSeTo+A6f0IBaQmYg== X-CSE-MsgGUID: Nsq0xSmnRzer9rMOLQJ5fw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,350,1744095600"; d="scan'208";a="162678720" Received: from johunt-mobl9.ger.corp.intel.com (HELO localhost) ([10.245.245.84]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2025 04:08:01 -0700 Date: Wed, 30 Jul 2025 13:07:57 +0200 From: Andi Shyti To: Krzysztof Karas Cc: intel-gfx@lists.freedesktop.org, Matthew Auld , Andi Shyti , Sebastian Brzezinka Subject: Re: [PATCH v2 1/2] drm/i915/selftests: Do not overwrite error code after intel_context_migrate_clear() call Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Krzysztof, On Wed, Jul 30, 2025 at 07:39:23AM +0000, Krzysztof Karas wrote: > Currently this function's error code is stored in err variable, > which, if a i915_request is present, will be immediately > overwritten by return from dma_resv_reserve_fences(). Call DMA > functions only if intel_context_migrate_clear() succeeded. > > Suggested-by: Matthew Auld > Signed-off-by: Krzysztof Karas Reviewed-by: Andi Shyti Andi