From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C15CC87FCB for ; Wed, 30 Jul 2025 13:19:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1063967.1429728 (Exim 4.92) (envelope-from ) id 1uh6i8-00015m-L8; Wed, 30 Jul 2025 13:19:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1063967.1429728; Wed, 30 Jul 2025 13:19:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uh6i8-00015f-Hx; Wed, 30 Jul 2025 13:19:12 +0000 Received: by outflank-mailman (input) for mailman id 1063967; Wed, 30 Jul 2025 13:19:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uh6i7-00015Z-Fk for xen-devel@lists.xenproject.org; Wed, 30 Jul 2025 13:19:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uh6i6-0099qD-2N; Wed, 30 Jul 2025 13:19:10 +0000 Received: from [2a01:cb15:80df:da00:4c1a:a750:6210:2b8] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uh6i6-00GwbI-1A; Wed, 30 Jul 2025 13:19:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=PM/A842BUuEmRphspvrC1nsJTWVXSYb1+n5lQ5WJEeU=; b=jJta3QwHrmbcXSRpUxFZX6oUOg p7o8uId0Yt/OruGbXnma8HNnCk7w8nr3BFxVZxfYjli0x9tMmTll8YCQRE0yebaSSPV2lHTeeUpfs NVT3eatjRXKqHoz7xDLTFavoEfDWgM1XUVJ3c16BJZdVUQF5lO1FYRVOQ3B/eX/9I518=; Date: Wed, 30 Jul 2025 15:19:07 +0200 From: Anthony PERARD To: Oleksii Moisieiev Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Anthony PERARD , Bertrand Marquis , Jan Beulich , Juergen Gross , Julien Grall , Michal Orzel , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Stefano Stabellini , Volodymyr Babchuk , Grygorii Strashko Subject: Re: [RFC PATCH v5 03/10] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent Message-ID: References: <3c8b292b345d81cd20ce260d45d3d7aac6d98702.1753184487.git.oleksii_moisieiev@epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c8b292b345d81cd20ce260d45d3d7aac6d98702.1753184487.git.oleksii_moisieiev@epam.com> On Tue, Jul 22, 2025 at 11:41:39AM +0000, Oleksii Moisieiev wrote: > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 4ffcbf624b..68d2ebeb9f 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1284,6 +1284,36 @@ out: > if (rc) exit(EXIT_FAILURE); > } > > +static int parse_arm_sci_config(XLU_Config *cfg, libxl_arm_sci *arm_sci, > + const char *str) > +{ > + int ret = 0; > + char *buf2, *ptr; > + char *oparg; > + > + if (NULL == (buf2 = ptr = strdup(str))) > + return ERROR_NOMEM; > + > + ptr = strtok(buf2, ","); > + while (ptr != NULL) > + { > + if (MATCH_OPTION("type", ptr, oparg)) { > + ret = libxl_arm_sci_type_from_string(oparg, &arm_sci->type); > + if (ret) { > + fprintf(stderr, "Unknown ARM_SCI type: %s\n", oparg); > + ret = ERROR_INVAL; > + goto parse_error; > + } > + } > + > + ptr = strtok(NULL, ","); > + } > + > +parse_error: This label could be named "out", as it just a path out of the function, both on success and error. > + free(buf2); > + return ret; > +} > + The patch looks fine to me for the toolstack part, so: Acked-by: Anthony PERARD # tools TODO on commit (or before): regen golang/xenlight/{helpers,types}.gen.go due to change in libxl_types.idl. Thanks, -- Anthony PERARD