Re: [PATCH RFC v1 1/1] ui/sdl2: clipboard sharing implementation for SDL

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Jul 30, 2025 at 12:23:32PM +0000, startergo wrote:
> From: startergo <startergo@protonmail.com>
> Date: Wed, 30 Jul 2025 12:13:25 +0000
> Subject: [PATCH] ui/sdl2: Add clipboard support with async handling
> 
> This patch adds clipboard support to the SDL2 UI backend with proper
> asynchronous clipboard request handling and QEMU clipboard subsystem
> integration.
> 
> Key features:
> - Runtime stability: QEMU starts and runs without crashes
> - Async handling: Proper async clipboard request tracking
> - Error handling: Comprehensive SDL error reporting
> - Memory management: Correct use of g_autofree and proper cleanup
> - QEMU integration: Full integration with QEMU's clipboard subsystem
> 
> The implementation includes:
> - New meson build option 'sdl_clipboard' (enabled by default)
> - Proper clipboard peer registration and notification handling
> - Async request handling to prevent blocking operations
> - Memory-safe string handling with proper null termination
> 
> Signed-off-by: startergo <startergo@protonmail.com>
> Co-authored-by: Kamay Xutax <admin@xutaxkamay.com>
> ---
> include/ui/sdl2.h | 8 ++
> meson.build | 3 +
> meson_options.txt | 2 +
> ui/meson.build | 3 +
> ui/sdl2-clipboard.c | 154 ++++++++++++++++++++++++++++++++++++++++++
> ui/sdl2.c | 9 +++
> 6 files changed, 179 insertions(+)
> create mode 100644 ui/sdl2-clipboard.c

> +static void sdl2_clipboard_clear_pending(void)
> +{
> + if (pending_request) {
> + if (pending_request->info) {
> + qemu_clipboard_info_unref(pending_request->info);
> + }
> + g_free(pending_request);
> + pending_request = NULL;
> + }
> +}

This mail came through as mixed text + html, and the text part has
completely mangled indentation....

There is no way we can accept the patch in this form, and there
isn't much point in reviewing it either as is.

If you can't get your mail client to send plain text mails without
mangling the patches, then the other option is to use 'git-publish'
as described here:

  https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches


Also, when posting new versions of a patch, please always send them
as a standalone new emails. Don't send them as a reply to old messages,
as that is liable to result in them going unseen by reviewers.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|